Skip to content

refactor(RingTheory/Ideal/Height): torwards private Ideal.primeHeight#37627

Open
Thmoas-Guan wants to merge 49 commits intoleanprover-community:masterfrom
Thmoas-Guan:refactor-primeHeight
Open

refactor(RingTheory/Ideal/Height): torwards private Ideal.primeHeight#37627
Thmoas-Guan wants to merge 49 commits intoleanprover-community:masterfrom
Thmoas-Guan:refactor-primeHeight

Conversation

@Thmoas-Guan
Copy link
Copy Markdown
Collaborator

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

PR summary c27c098f0d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Ideal.height_add_one_le_of_lt_of_isPrime
+ Ideal.height_eq_inf_minimalPrimes
+ Ideal.height_eq_order_height_of_isPrime
+ Ideal.height_eq_ringKrullDim_iff
+ Ideal.height_eq_zero_iff
+ Ideal.height_le_ringKrullDim_of_isPrime
+ Ideal.height_lt_top_of_isPrime
+ Ideal.height_mono_of_isPrime
+ Ideal.height_ne_top_of_isPrime
+ Ideal.height_strict_mono_of_isPrime
+ Ideal.height_strict_mono_of_isPrime_of_isPrime
+ Ideal.height_strict_mono_of_isPrime_of_is_prime
+ Ideal.isMaximal_of_height_eq_ringKrullDim
+ Ideal.le_minimalPrimes
+ Ideal.sup_height_isPrime_eq_ringKrullDim
+ Ideal.sup_height_of_maximal_eq_ringKrullDim
+ IsLocalization.height_comap_eq_of_isPrime
+ minimalPrimes_isPrime
- Ideal.height_strict_mono_of_is_prime

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Apr 4, 2026
@Thmoas-Guan Thmoas-Guan added the WIP Work in progress label Apr 4, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Apr 4, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 14, 2026
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-ring-theory Ring theory WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant