Skip to content

chore: fix diamonds for Real/Complex Algebra instances#36087

Closed
matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
matthewjasper:fix-rc-diamonds
Closed

chore: fix diamonds for Real/Complex Algebra instances#36087
matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
matthewjasper:fix-rc-diamonds

Conversation

@matthewjasper
Copy link
Copy Markdown
Collaborator

@matthewjasper matthewjasper commented Mar 3, 2026

Unfold or make implicit_reducible some definitions used to define Algebra ℝ ℂ . This should allow reducing use of set_option backward.isDefEq.respectTransparency false.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

PR summary 5308bb723e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (3.00, 0.00)
Current number Change Type
7347 -3 backward.isDefEq

Current commit 22c765ddf9
Reference commit 5308bb723e

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/Data/Complex/Basic.lean
@matthewjasper

This comment has been minimized.

@matthewjasper matthewjasper force-pushed the fix-rc-diamonds branch 2 times, most recently from e73893a to d9a9bb4 Compare March 5, 2026 10:25
@jsm28 jsm28 removed their assignment Mar 9, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 10, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 10, 2026
Comment on lines +354 to +355
algebraMap.__ := (algebraMap R A).comp f
algebraMap.toFun x := algebraMap R A (f x)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand why you're doing it, but this change and the one to algebraMap above look fishy; could you split off the less-controversial refactors about RestrictScalars into a pre-work PR so that these changes can be reviewed in isolation?

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 15, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 25, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

This PR/issue depends on:

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 25, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 28, 2026
@matthewjasper matthewjasper added the awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there label Mar 29, 2026
@matthewjasper
Copy link
Copy Markdown
Collaborator Author

closing in favour of #38451

@matthewjasper matthewjasper deleted the fix-rc-diamonds branch April 24, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants