chore: fix diamonds for Real/Complex Algebra instances#36087
Closed
matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
Closed
chore: fix diamonds for Real/Complex Algebra instances#36087matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
matthewjasper wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
PR summary 5308bb723eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (3.00, 0.00)
Current commit 22c765ddf9 You can run this locally as
|
matthewjasper
commented
Mar 4, 2026
This comment has been minimized.
This comment has been minimized.
e73893a to
d9a9bb4
Compare
|
This pull request has conflicts, please merge |
d9a9bb4 to
af6d059
Compare
eric-wieser
reviewed
Mar 14, 2026
Comment on lines
+354
to
+355
| algebraMap.__ := (algebraMap R A).comp f | ||
| algebraMap.toFun x := algebraMap R A (f x) |
Member
There was a problem hiding this comment.
I understand why you're doing it, but this change and the one to algebraMap above look fishy; could you split off the less-controversial refactors about RestrictScalars into a pre-work PR so that these changes can be reviewed in isolation?
|
This PR/issue depends on:
|
|
This pull request has conflicts, please merge |
af6d059 to
22c765d
Compare
Collaborator
Author
|
closing in favour of #38451 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfold or make
implicit_reduciblesome definitions used to defineAlgebra ℝ ℂ. This should allow reducing use ofset_option backward.isDefEq.respectTransparency false.RestrictScalars#36694