Skip to content

feat: lemmas for the analytic part of the proof of the Gelfond–Schneider theorem (Part 4/5)#35316

Open
mkaratarakis wants to merge 15 commits intoleanprover-community:masterfrom
mkaratarakis:analysispart4
Open

feat: lemmas for the analytic part of the proof of the Gelfond–Schneider theorem (Part 4/5)#35316
mkaratarakis wants to merge 15 commits intoleanprover-community:masterfrom
mkaratarakis:analysispart4

Conversation

@mkaratarakis
Copy link
Copy Markdown
Contributor

@mkaratarakis mkaratarakis commented Feb 14, 2026


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 14, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 14, 2026

PR summary 96eec06566

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.Transcendental.AnalyticPart (new file) 2499

Declarations diff

+ analyticOrderAt_deriv_eq_top_iff_of_eq_zero
+ analyticOrderAt_deriv_order_eq_succ
+ analyticOrderAt_eq_nat_iff_iteratedDeriv_eq_zero
+ le_analyticOrderAt_iff_iteratedDeriv_eq_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Feb 14, 2026
Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart.lean
Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart Outdated
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 18, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 10, 2026
@mathlib-dependent-issues
Copy link
Copy Markdown

Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart.lean Outdated
Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart.lean Outdated
Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart.lean Outdated
Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart.lean Outdated
Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart.lean Outdated
Comment thread Mathlib/NumberTheory/Transcendental/AnalyticPart.lean Outdated
@MichaelStollBayreuth MichaelStollBayreuth added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 30, 2026
@mkaratarakis
Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 31, 2026
/-!
Auxiliary lemmata covering the analytic part of the proof of the Gelfond–Schneider theorem.
Move to appropriate files in Analysis/Complex or Analysis/Analytic and change docstring accordingly.
-/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the lemmas to Mathlib.Analysis.Analytic.Order (where the other results on analyticOrderAt also reside) and remove this file (don't forget to also remove the import from Mathlib.lean).

| some 0 =>
have Hn_zero : analyticOrderAt f z₀ = 0 := Hn'
exact hf.analyticOrderAt_eq_zero.mp Hn_zero hzero |>.elim
| some (n'' + 1) =>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why n'' and not simply n (or n', but I don't think there is another n here that would be relevant)?

have Hn_coe : analyticOrderAt f z₀ = ↑(n'' + 1) := Hn'
have := horder ▸ analyticOrderAt_deriv_of_pos hf Hn_coe
norm_cast at this ⊢
have hchar : ringChar ℂ = 0 := by aesop
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
have hchar : ringChar ℂ = 0 := by aesop
have hchar : ringChar ℂ = 0 := ringChar.eq ℂ 0


lemma analyticOrderAt_eq_nat_iff_iteratedDeriv_eq_zero {f : ℂ → ℂ} {z₀ : ℂ} {n : ℕ}
(hf : AnalyticAt ℂ f z₀) :
analyticOrderAt f z₀ = n ↔ (∀ k < n, deriv^[k] f z₀ = 0) ∧ deriv^[n] f z₀ ≠ 0 := by
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use iteratedDeriv? Thre is more API (loogle says 169 decls compared to 44) than for deriv^[n].

@MichaelStollBayreuth MichaelStollBayreuth added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 19, 2026
@kebekus
Copy link
Copy Markdown
Collaborator

kebekus commented Apr 21, 2026

@MichaelStollBayreuth Will review as requested, but might not be able to do that before the weekend (=25/26Apr). Sorry for being slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants