[Merged by Bors] - fix: do not remove reactions if the corresponding label is still present on the PR#27570
Closed
bryangingechen wants to merge 5 commits intoleanprover-community:masterfrom
Closed
Conversation
bryangingechen
added
the
CI
PR summary f5ed73d3f3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
adomani
reviewed
Jul 28, 2025
bryangingechen
added
the
awaiting-author
bryangingechen
removed
the
awaiting-author
grunweg
reviewed
Aug 1, 2025
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Thanks! First look looks good, just minor comments (and future-proofing).
grunweg
added
the
awaiting-author
Contributor
|
Just took a second look again. The bug you described is subtles (yikes!), thanks a lot for finding and fixing it! |
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
ghost
added
the
maintainer-merge
bryangingechen
removed
the
awaiting-author
Contributor
Author
|
This should be ready now, thanks for the reviews! |
adomani
reviewed
Aug 8, 2025
Contributor
adomani
left a comment
adomani
left a comment
There was a problem hiding this comment.
Thank you for this fix: let's see how it works!
bors merge
ghost
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
…ent on the PR (#27570) Recently the reaction bot on Zulip has been observed to add a reaction and then remove it shortly afterwards (mainly the reactions corresponding to the `ready-to-merge` and `delegated` labels). The mechanism seems to be the following: - a maintainer writes a comment like "bors merge" (or "bors d+") on a PR that has been `maintainer-merge`'d - `zulip_emoji_merge_delegate.yaml` and `zulip_emoji_merge_delegate_wf.yaml` react to this comment and: - simultaneously adds the "ready-to-merge" and removes the `maintainer-merge` label - adds the "merge" emoji reaction on Zulip - the `zulip_emoji_labelling.yaml` workflow reacts to the `maintainer-merge` label being removed, and clears the "merge" emoji as well. See [this log](https://github.com/leanprover-community/mathlib4/actions/runs/16270158496/job/45935446666#step:5:30) (which removes the "delegated" emoji). We change the `zulip_emoji_labelling.yaml` workflow so that it passes the current list of labels on the PR to the `zulip_emoji_reactions.py` script, and also change the script so that it only removes a reaction if the corresponding label is NOT present. cf. https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/merge.2Fdelegate.20emojis.20bot/near/528289834
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…ent on the PR (leanprover-community#27570) Recently the reaction bot on Zulip has been observed to add a reaction and then remove it shortly afterwards (mainly the reactions corresponding to the `ready-to-merge` and `delegated` labels). The mechanism seems to be the following: - a maintainer writes a comment like "bors merge" (or "bors d+") on a PR that has been `maintainer-merge`'d - `zulip_emoji_merge_delegate.yaml` and `zulip_emoji_merge_delegate_wf.yaml` react to this comment and: - simultaneously adds the "ready-to-merge" and removes the `maintainer-merge` label - adds the "merge" emoji reaction on Zulip - the `zulip_emoji_labelling.yaml` workflow reacts to the `maintainer-merge` label being removed, and clears the "merge" emoji as well. See [this log](https://github.com/leanprover-community/mathlib4/actions/runs/16270158496/job/45935446666#step:5:30) (which removes the "delegated" emoji). We change the `zulip_emoji_labelling.yaml` workflow so that it passes the current list of labels on the PR to the `zulip_emoji_reactions.py` script, and also change the script so that it only removes a reaction if the corresponding label is NOT present. cf. https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/merge.2Fdelegate.20emojis.20bot/near/528289834
Paul-Lez
pushed a commit
to Paul-Lez/mathlib4
that referenced
this pull request
Aug 23, 2025
…ent on the PR (leanprover-community#27570) Recently the reaction bot on Zulip has been observed to add a reaction and then remove it shortly afterwards (mainly the reactions corresponding to the `ready-to-merge` and `delegated` labels). The mechanism seems to be the following: - a maintainer writes a comment like "bors merge" (or "bors d+") on a PR that has been `maintainer-merge`'d - `zulip_emoji_merge_delegate.yaml` and `zulip_emoji_merge_delegate_wf.yaml` react to this comment and: - simultaneously adds the "ready-to-merge" and removes the `maintainer-merge` label - adds the "merge" emoji reaction on Zulip - the `zulip_emoji_labelling.yaml` workflow reacts to the `maintainer-merge` label being removed, and clears the "merge" emoji as well. See [this log](https://github.com/leanprover-community/mathlib4/actions/runs/16270158496/job/45935446666#step:5:30) (which removes the "delegated" emoji). We change the `zulip_emoji_labelling.yaml` workflow so that it passes the current list of labels on the PR to the `zulip_emoji_reactions.py` script, and also change the script so that it only removes a reaction if the corresponding label is NOT present. cf. https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/merge.2Fdelegate.20emojis.20bot/near/528289834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently the reaction bot on Zulip has been observed to add a reaction and then remove it shortly afterwards (mainly the reactions corresponding to the
ready-to-mergeanddelegatedlabels). The mechanism seems to be the following:maintainer-merge'dzulip_emoji_merge_delegate.yamlandzulip_emoji_merge_delegate_wf.yamlreact to this comment and:maintainer-mergelabelzulip_emoji_labelling.yamlworkflow reacts to themaintainer-mergelabel being removed, and clears the "merge" emoji as well. See this log (which removes the "delegated" emoji).We change the
zulip_emoji_labelling.yamlworkflow so that it passes the current list of labels on the PR to thezulip_emoji_reactions.pyscript, and also change the script so that it only removes a reaction if the corresponding label is NOT present.cf. https://leanprover.zulipchat.com/#narrow/channel/345428-mathlib-reviewers/topic/merge.2Fdelegate.20emojis.20bot/near/528289834