Skip to content

[Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also #24544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grunweg wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also #24544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f461d1e
feat(CI): add emoji to maintainer merge'd PRs also
grunweg May 2, 2025
20125e6
Also print LABEL_STATUS
grunweg May 2, 2025
e2a5289
refactor: consolidate in one workflow, and rename
grunweg May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...orkflows/zulip_emoji_awaiting_author.yaml → .github/workflows/zulip_emoji_labelling.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ on:
pull_request:
types: [labeled, unlabeled]
jobs:
# When a PR is (un)labelled with awaiting-author or maintainer-merge,
# add resp. remove the matching emoji reaction from zulip messages.
set_pr_emoji:
if: github.event.label.name == 'awaiting-author'
if: github.event.label.name == 'awaiting-author' || github.event.label.name == 'maintainer-merge'
runs-on: ubuntu-latest
steps:
- name: Checkout mathlib repository
Expand All @@ -30,5 +32,5 @@ jobs:
PR_NUMBER: ${{ github.event.number}}
LABEL_STATUS: ${{ github.event.action }}
run: |
printf $'Running the python script with pr "%s"\n' "$PR_NUMBER"
printf $'Running the python script with pr "%s"\n' "$PR_NUMBER" "$LABEL_STATUS"
python scripts/zulip_emoji_merge_delegate.py "$ZULIP_API_KEY" "$ZULIP_EMAIL" "$ZULIP_SITE" "$LABEL_STATUS" "$PR_NUMBER"
14 changes: 14 additions & 0 deletions scripts/zulip_emoji_merge_delegate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
has_bors = any(reaction['emoji_name'] == 'bors' for reaction in reactions)
has_merge = any(reaction['emoji_name'] == 'merge' for reaction in reactions)
has_awaiting_author = any(reaction['emoji_name'] == 'writing' for reaction in reactions)
has_maintainer_merge = any(reaction['emoji_name'] == 'hammer' for reaction in reactions)
has_closed = any(reaction['emoji_name'] == 'closed-pr' for reaction in reactions)
first_in_thread = hashPR.search(message['subject']) and message['display_recipient'] == 'PR reviews' and message['subject'] not in first_by_subject
first_by_subject[message['subject']] = message['id']
Expand Down Expand Up @@ -105,6 +106,13 @@
"emoji_name": "merge"
})
print(f"result: '{result}'")
if has_maintainer_merge:
print('Removing maintainer-merge')
result = client.remove_reaction({
"message_id": message['id'],
"emoji_name": "hammer"
})
print(f"result: '{result}'")
if has_awaiting_author:
print('Removing awaiting-author')
result = client.remove_reaction({
Expand Down Expand Up @@ -137,6 +145,12 @@
"message_id": message['id'],
"emoji_name": "peace_sign"
})
elif 'maintainer-merge' == LABEL:
print('adding maintainer-merge')
client.add_reaction({
"message_id": message['id'],
"emoji_name": "hammer"
})
elif LABEL == 'labeled':
print('adding awaiting-author')
client.add_reaction({
Expand Down