[Merged by Bors] - feat: have ring_nf fail if no progress#24529
Closed
[Merged by Bors] - feat: have ring_nf fail if no progress#24529
ring_nf fail if no progress#24529Conversation
PR summary 30762f3b8fImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
grunweg
reviewed
May 2, 2025
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Seems reasonable (though I'm not an expert on ring_nf). Can you extend the PR description a bit to motivate why this is useful (as opposed to a built-in version of the unusedTactic linter)?
grunweg
added
the
awaiting-author
Co-authored-by: Michael Rothgang <rothgami@math.hu-berlin.de>
plp127
removed
the
awaiting-author
grunweg
reviewed
May 12, 2025
Contributor
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
github-actions
Bot
added
the
maintainer-merge
Contributor
|
bors d+ |
Contributor
|
✌️ plp127 can now approve this pull request. To approve and merge a pull request, simply reply with |
ghost
added
delegated
Contributor
Author
|
bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
May 13, 2025
Makes `ring_nf` fail if no progress is made, and adds a new option `failIfUnchanged` (default value := `true`) to the config. Motivated by stanford-centaur/PyPantograph#97. The unusedTactic linter is not sufficient here because it fails in the presence of certain errors (for example, `unsolved goals`).
Contributor
|
Pull request successfully merged into master. Build succeeded:
|
mathlib-bors
Bot
changed the title
ring_nf fail if no progressring_nf fail if no progress
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
Makes `ring_nf` fail if no progress is made, and adds a new option `failIfUnchanged` (default value := `true`) to the config. Motivated by stanford-centaur/PyPantograph#97. The unusedTactic linter is not sufficient here because it fails in the presence of certain errors (for example, `unsolved goals`).
jano-wol
pushed a commit
that referenced
this pull request
May 16, 2025
Makes `ring_nf` fail if no progress is made, and adds a new option `failIfUnchanged` (default value := `true`) to the config. Motivated by stanford-centaur/PyPantograph#97. The unusedTactic linter is not sufficient here because it fails in the presence of certain errors (for example, `unsolved goals`).
bwehlin
pushed a commit
to bwehlin/mathlib4
that referenced
this pull request
May 31, 2025
Makes `ring_nf` fail if no progress is made, and adds a new option `failIfUnchanged` (default value := `true`) to the config. Motivated by stanford-centaur/PyPantograph#97. The unusedTactic linter is not sufficient here because it fails in the presence of certain errors (for example, `unsolved goals`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
ring_nffail if no progress is made, and adds a new optionfailIfUnchanged(default value :=true) to the config.Motivated by stanford-centaur/PyPantograph#97. The unusedTactic linter is not sufficient here because it fails in the presence of certain errors (for example,
unsolved goals).