-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Merged by Bors] - feat: a linter to enforce formatting #24465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 217 commits
Commits
Show all changes
313 commits
Select commit
Hold shift + click to select a range
e73e820
compressDocs
adomani f02d337
docs and compressDocs option
adomani b658b1b
cleanup and tests
adomani a1983b4
one more doc
adomani 088a047
chore: whitespace in the presence of doc-strings
adomani b7c86c4
remove commented dbg_traces, better push
adomani 08530e2
one more
adomani 7a8af48
more whitespace
adomani 4f7c0ba
more whitespace
adomani d9af631
Merge branch 'whitespace/here_we_go_again6' into adomani/pplint_some_…
adomani 8d2ded1
omit one more and not
adomani b4ed4e0
more
adomani 870e15a
Merge branch 'whitespace/here_we_go_again6' into adomani/pplint_some_…
adomani 2a2065f
more
adomani 52f6080
Merge branch 'whitespace/here_we_go_again6' into adomani/pplint_some_…
adomani f02ecf2
lint some to_additive docstrings
adomani 27ea3c6
Add parallelScan
adomani 90d2562
remove ascription
adomani 87bc4b1
shorten, FormatError
adomani f75a5d5
remove one field from error, cleanup
adomani a4d9493
better error formatting
adomani 5290868
count from end
adomani 9ec8128
remove length input
adomani ef54626
add fmtPos
adomani 0a31a99
remove default values
adomani 3f07439
formatting
adomani 5720dbf
lint
adomani e3bcd91
more lint
adomani 317594a
mkFormatError
adomani 44a9c7b
add srcPos' a position, really
adomani 5cbb481
remove default value
adomani 9b4af9e
rename fields
adomani fb1bbfa
streamLine
adomani fae6cd5
treat partly also M
adomani ec94e70
process strings
adomani f1dcc5a
trimLeft
adomani 3ea00c6
trimLeft also L
adomani 9821bbb
changes to Mathlib/Data/Nat/Basic.lean
adomani 1c228e6
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 066a334
typos
adomani ea58a83
logLint, better message and some adaptations in tests
adomani 3c2d704
FormatError docs, add length, add pushFormatError
adomani 8c7eefe
use pushFormatError
adomani 6f782fd
compute length as stringPos
adomani 8d92443
remove comment
adomani a48397a
add ctx
adomani 6dcfb90
try to limit
adomani 931db44
add unlinted ranges
adomani 9e16841
reduce exceptions
adomani ba40d5f
cleanup Mathlib/Data/Nat/Basic.lean
adomani 677c6a1
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 9abcda5
shorter tests
adomani 771b69c
update mathlib
adomani 7fd950b
chore: whitespace adaptations
adomani e800d00
Merge branch 'whitespace/more_updates' into test/recoverpplint
adomani 4477681
skip macro_rules
adomani b752ba5
chore: whitespace fixes
adomani 921c1d5
ignore superscripts
adomani 3b40153
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani cdfe9f8
chore: further whitespace fixes
grunweg 00b69f0
chore(IsManifold): use modern config syntax
grunweg 64b5287
more fixes
grunweg 53c1b43
chore: more whitespace fixes
grunweg 1dcf229
chore: use modern config syntax
grunweg a06e5f4
chore: more whitespace fixes
grunweg f6377b0
Last batch?
grunweg 7a7cfb5
Ignore Bundle.TotalSpace.proj and Finset.slice
adomani d654ba4
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani d48c205
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani c17025a
Apply suggestions from code review
adomani 3e13e3e
manually remove comments starting with `--`
adomani 127f57a
fix tests
adomani a8213db
more silent tests
adomani 095f9b3
unlint doc-strings
adomani 30f1b71
unlint omit
adomani 228ccff
Try to handle comments
adomani 772af59
more comment fix
adomani 002bcf8
chore: whitespace adaptations
adomani 2e5687b
chore: whitespace adaptations
adomani b8e8415
remove unwanted file
adomani 6413d57
Merge branch 'whitespace/yet_more_adaptations' into test/recoverpplint
adomani b2cd73b
allow string literals, subscripts and aesop rulesets
adomani b16b63b
docs
adomani 20876f3
Skip run_cmd
adomani 59c3490
punt on `Oh no!"
adomani c0c0bec
fix inductive
adomani 64d6259
improved tests
adomani f0d2053
Update CoprodI.lean
adomani 38cc18a
Update Multiplication.lean
adomani af4d2ae
Update Imo2019Q4.lean
adomani d63def2
Merge branch 'master' into test/recoverpplint
Parcly-Taxel e41d214
chore(MathlibTest/linarith): add spaces around binary operators
grunweg f07349d
chore(MathlibTest): fix style issues; disable the commandStart linter…
grunweg 07e9a11
chore(MathlibTest/norm_num): don't indent sections
grunweg 5c0ab2c
chore: more miscellaneous fixes
grunweg dfeb277
chore: a few more test fixes
grunweg ac14b2a
chore: whitespace still
adomani 02590d7
update linter
adomani 9d83ba4
Merge branch 'whitespace/further_changes' into test/recoverpplint
adomani 3ba90ec
remove irrecoverable test
adomani 3a47c5d
remove unwanted file
adomani 707be72
restore Mathlib/Topology/CWComplex/Classical/Basic.lean
adomani 5a6b782
no hello
adomani 5beb7f4
a recent addition
adomani f917151
Merge branch 'whitespace/further_changes' into test/recoverpplint
adomani bec476e
clean up exceptions
adomani 0988183
prune comments
adomani 7054aec
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 762b123
chore: simp_rw changes
grunweg a71d881
chore: simp(a) +contextual
grunweg f904198
Fix minImports
adomani 3cae2d8
chore: big combination of things
grunweg 7886b64
shake
adomani b5094fe
set option to false
adomani 5f0e1df
Merge remote-tracking branch 'origin/MR-more-config' into test/recove…
adomani 6460375
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani ff7f2b2
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 0ee9c3f
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 37c262b
fix: pretty-printing of `#min_imports in`
adomani 4dd03fe
Merge branch 'adomani/min_imports_in_pp' into test/recoverpplint
adomani 371bb5c
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 458efe7
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 77b8f13
Use `mkWindow`
adomani e315911
reformulate message
adomani 9ebd91c
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani a3e3743
include better pp output
adomani 556089d
reformat message
adomani 04c9915
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 426779f
chore: whitespace fixes
adomani 09cff1c
chore: whitespace fixes
adomani 06cebb9
Merge branch 'whitespace/cat_theory' into test/recoverpplint
adomani 4ee2fbc
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani c75c872
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani f71f7db
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 49b75cd
chore: whitespace fixes
adomani d29b595
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 840f3b9
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 914a566
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 61de019
chore: whitespace fixes
adomani 44010dc
chore: whitespace fixes
adomani 3a86e86
Merge branch 'whitespace/more_linter_whitespace' into test/recoverpplint
adomani ff9072b
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 6e3aa42
chore: whitespace adaptations
adomani 5abbaf2
chore: whitespace adaptations
adomani bb92df1
Merge branch 'whitespace/more_updates1' into test/recoverpplint
adomani 2a4d08b
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 0fd52ff
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani c4c18e2
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani ffbe5b0
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani b5de810
fix(whitespace): better `≡ᵀ` pretty-print and remove a space
adomani 916ccad
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani f8a942c
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani c0e57be
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 1766ea3
fix(whitespace): random spaces
adomani ec8d9d8
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 47b7f73
doc-string typo
adomani adb8ac9
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 0f36652
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 0f1eee0
fix: whitespace
adomani 59fa7e5
fix: whitespace
adomani 58bd689
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani d25b87c
add comment about merged Aesop pretty-printing
adomani 5b004d6
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani df06296
remove aesop exception
adomani 1d7b72a
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 5ad10ec
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 9b0ae8c
one more
adomani a81f7eb
Merge remote-tracking branch 'origin/master' into whitespace/two_more
adomani dc4b3d6
one more
adomani 565c662
Merge branch 'whitespace/two_more' into test/recoverpplint
adomani 9721f5c
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 4fb6a9c
whitespace
adomani 44d4a05
Merge remote-tracking branch 'origin/master' into whitespace/two_more
adomani 671c9a9
whitespace
adomani fa51991
Merge branch 'whitespace/two_more' into test/recoverpplint
adomani b233d52
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani a8f9505
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani ad89804
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 3ceb619
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 4207bd4
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 34d8a91
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 7efd171
another fix
adomani e83efc8
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani fad36b0
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 44288cf
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani b1cb0db
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 9959839
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 6746824
chore: remove whitespace
adomani 88016b1
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 5dd295a
update to linteroptions
adomani aa33ae9
chore: remove whitespace
adomani f8b2a25
chore: remove whitespace
adomani f0fc7c8
remove argument
adomani d3880de
reset
adomani 7095b6b
Merge branch 'whitespace/remove_more' into test/recoverpplint
adomani 9f9766a
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 399dc40
look at omit
adomani c69235f
chore
adomani e03fcb0
no limit awareness
adomani c949dec
some limits
adomani 67bc8a3
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani feabc5c
first batch of comments
adomani 9974ec7
Apply suggestions from code review
adomani 3b9856b
Merge branch 'test/recoverpplint' of github.com:leanprover-community/…
adomani da42c33
perf: return early if there is nothing to scan
grunweg 80d0143
Some nits from code review
grunweg afae85d
Import linter in the right place
grunweg b00ed06
Tweak test file
grunweg 3c74b68
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 695e2ef
chore: remove file from other PR
grunweg 662f5aa
chore: fix miscelleneous spaces
grunweg 5a8cd76
chore(test): group test cases a bit better
grunweg 7663f7d
chore: add test for a current false positive
grunweg 51eb1f8
One more test for false positives
grunweg aec275e
And a third one, for intended behaviour
grunweg bd99ba1
Merge branch 'test/recoverpplint' of github.com:leanprover-community/…
adomani 4e79c8d
Reduce diff
grunweg 44d107b
Three more spaces
grunweg 3796e15
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani 7b951f5
RFC: notation_class* --- please double-check
grunweg 2a6fcf8
chore: allow three instnaces of manual alignment, for now
grunweg 0a688f6
chore: remove some manual alignment
grunweg 451869d
double quoted names
adomani 36058e1
Merge branch 'test/recoverpplint' of github.com:leanprover-community/…
adomani 5f5ea58
fixes
adomani f68e26d
Try adding a test for the last error in mathlib: somehow, this doesn'…
grunweg dbda40a
Merge branch 'master' into test/recoverpplint
grunweg 40fc1a6
temp: disable linter once
grunweg ed71747
Fix `where` exception
adomani 1408891
Merge branch 'test/recoverpplint' of github.com:leanprover-community/…
adomani 794aa3e
remove exception
adomani 04e0bae
Remove duplicate test
grunweg 0eff3ec
Move
grunweg e491981
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani ec564cb
Clarify `isOutside`
adomani 1ffe9e9
Add test for `mkWindow`
adomani dc3d804
remove noise
adomani 280ba7d
Merge remote-tracking branch 'origin/master' into test/recoverpplint
adomani c464f61
Update Mathlib/Tactic/Linter/CommandStart.lean
adomani 098197a
Merge remote-tracking branch 'upstream/master' into test/recoverpplint
adomani b1cf682
chore: whitespace fixes
adomani c33b15a
Merge remote-tracking branch 'upstream/master' into test/recoverpplint
adomani 3939982
chore: adapt whitespace
adomani 7f85cb7
explain comments and doc-strings
adomani 0d0aa08
Apply suggestions from code review
adomani 0e05ae2
Merge branch 'test/recoverpplint' of github.com:leanprover-community/…
adomani b5df788
Merge remote-tracking branch 'upstream/master' into test/recoverpplint
adomani eafbad4
remove whitespace
adomani 25c78c4
long line
adomani 479f72c
fix
adomani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.