Conversation
Signed-off-by: shivam tyagi <shivamtyagi@shivams-MacBook-Air.local>
|
@Rajesh-Nagarajan-11 please review! thanks |
| npm install | ||
|
|
||
| # Start the development server | ||
| start: |
| npm run test | ||
|
|
||
| # Clean up build artifacts and installed modules | ||
| clean: |
There was a problem hiding this comment.
@indevi it should be coming from package.json means add a clean script in package.json then use like npm run clean.
There was a problem hiding this comment.
okay considering the scope, its best i remove clean command
| # Install project dependencies | ||
| install: | ||
| npm install | ||
|
|
There was a problem hiding this comment.
add make site it should run both npm install then npm run dev
There was a problem hiding this comment.
hope this is what you are looking for here @saurabhraghuvanshii
There was a problem hiding this comment.
@indevi this is good but can you refer this https://github.com/layer5io/layer5/blob/master/Makefile once
There was a problem hiding this comment.
refered and added a echo message
Signed-off-by: shivam tyagi <shivamtyagi@shivams-MacBook-Air.local>
|
@saurabhraghuvanshii thanks for the indepth help, let me know if this improvements are good |
Combine site installation and development server start commands into one. Signed-off-by: shivam tyagi <tyagishivam.dev@gmail.com>
|
yes please check now @saurabhraghuvanshii |
|
Thanks @indevi lgtm!! |
|
https://github.com/layer5io/mui-datatables/blob/master/.github%2Fworkflows%2Fpublish-package.yml update this workflow as well to use make commands |
|
will updating this workflow part of this PR itself or i have to create a new branch? @Rajesh-Nagarajan-11 |
|
In this PR itself Good to go |
3 participants
Notes for Reviewers
This PR fixes #42
Signed commits