Skip to content

Fixes "Unexpected X" error in 5.3#9

Open
psaunders wants to merge 2 commits into
laracasts:masterfrom
psaunders:master
Open

Fixes "Unexpected X" error in 5.3#9
psaunders wants to merge 2 commits into
laracasts:masterfrom
psaunders:master

Conversation

@psaunders

Copy link
Copy Markdown

In prior versions of Laravel, when registering custom Blade directives using the directive method, the $expression passed to your directive callback contained the outer-most parenthesis. In Laravel 5.3, these outer-most parenthesis are not included in the expression passed to your directive callback.

@laracasts

Copy link
Copy Markdown
Collaborator

But this now means that 5.3 is the minimum requirement, right?

@psaunders

psaunders commented Sep 12, 2016

Copy link
Copy Markdown
Author

Yes. It'd have to be a new tag/version. Alternatively the readme could be amended to have an aside for 5.3

 "If >= 5.3 @cache(($thing))" 

Or there could be a parenthesis/version check in MatryoshkaServiceProvider. I'll leave it to you, let me know if you want one of those in the PR.

This has been a handy package BTW.

@willvincent

Copy link
Copy Markdown

Fixed to add support to 5.3, without removing support for 5.2 in PR #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants