fix: handle null summary_index_setting in KnowledgeIndexNodeData#36355
Open
EvanYao826 wants to merge 1 commit into
Open
fix: handle null summary_index_setting in KnowledgeIndexNodeData#36355EvanYao826 wants to merge 1 commit into
EvanYao826 wants to merge 1 commit into
Conversation
When summary_index_setting is a dict with enable=None (e.g. from a Knowledge Pipeline without summary indexing configured), Pydantic validation fails because enable expects bool, not None. Added a field_validator to normalize dicts with enable=None to None. Fixes langgenius#36233
dosubot
Bot
added
the
size:S
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When creating a Knowledge Pipeline without summary indexing configured, the
summary_index_settingfield is sent as{"enable": null}instead ofnull. This causes Pydantic validation to fail:Fix
Added a
field_validatorwithmode="before"toKnowledgeIndexNodeDatathat normalizes dicts withenable=None(or missingenable) toNone.Fixes #36233