Skip to content

feat(dify-ui): add shared form primitives#36334

Merged
lyzno1 merged 21 commits into
mainfrom
codex/dify-ui-form-system
May 19, 2026
Merged

feat(dify-ui): add shared form primitives#36334
lyzno1 merged 21 commits into
mainfrom
codex/dify-ui-form-system

Conversation

@lyzno1
Copy link
Copy Markdown
Member

@lyzno1 lyzno1 commented May 18, 2026

Summary

  • add shared Base UI Form, Field, and Fieldset primitives in dify-ui
  • align field anatomy with Dify Design Kit input, label, help text, and error styles
  • compose checkbox group usage with Fieldset semantics and regroup form-control stories

Validation

  • pnpm --dir packages/dify-ui test
  • pnpm --dir packages/dify-ui type-check
  • pnpm --dir web test app/components/base/checkbox-list/tests/index.spec.tsx
  • pnpm --dir web type-check
  • git diff --check

Fixes #36333

@github-actions github-actions Bot added the web This relates to changes on the web. label May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.96%. Comparing base (2d5186f) to head (a6af695).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #36334   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files        4455     4458    +3     
  Lines      211543   211564   +21     
  Branches    39527    39536    +9     
=======================================
+ Hits       181847   181876   +29     
+ Misses      26482    26474    -8     
  Partials     3214     3214           
Flag Coverage Δ
api 85.49% <100.00%> (+<0.01%) ⬆️
dify-ui 94.80% <100.00%> (+0.21%) ⬆️
web 86.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1 lyzno1 marked this pull request as ready for review May 18, 2026 09:36
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update javascript code labels May 18, 2026
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels May 18, 2026
@lyzno1 lyzno1 changed the title feat: add shared form primitives feat(dify-ui): add shared form primitives May 18, 2026
@lyzno1 lyzno1 enabled auto-merge May 18, 2026 10:28
@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels May 18, 2026
@lyzno1 lyzno1 requested a review from QuantumGhost as a code owner May 18, 2026 14:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 0.00% 44.43% +44.43%
Strict coverage 0.00% 43.96% +43.96%
Typed symbols 0 22,544 +22,544
Untyped symbols 0 28,499 +28,499
Modules 0 2562 +2,562

@lyzno1 lyzno1 force-pushed the codex/dify-ui-form-system branch from 28fe35a to 91b67ba Compare May 18, 2026 14:33
@lyzno1 lyzno1 force-pushed the codex/dify-ui-form-system branch from 91b67ba to d8dd5fe Compare May 18, 2026 14:41
@lyzno1 lyzno1 requested a review from zhsama as a code owner May 19, 2026 03:02
@lyzno1 lyzno1 disabled auto-merge May 19, 2026 03:30
@lyzno1 lyzno1 marked this pull request as draft May 19, 2026 03:30
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 19, 2026
@lyzno1 lyzno1 marked this pull request as ready for review May 19, 2026 05:38
@lyzno1 lyzno1 added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 04d6286 May 19, 2026
37 checks passed
@lyzno1 lyzno1 deleted the codex/dify-ui-form-system branch May 19, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize form semantics in web UI

2 participants