chore(api): annotate simple contract responses#36331
Draft
hyoban wants to merge 14 commits into
Draft
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-18 10:31:53.029870873 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-18 10:31:42.570770704 +0000
@@ -1,9 +1,9 @@
ERROR `str` is not assignable to `Literal['advanced-chat', 'agent-chat', 'all', 'channel', 'chat', 'completion', 'workflow']` [bad-assignment]
- --> controllers/console/app/app.py:69:104
+ --> controllers/console/app/app.py:70:104
ERROR Object of class `App` has no attribute `access_mode` [missing-attribute]
- --> controllers/console/app/app.py:583:13
+ --> controllers/console/app/app.py:585:13
ERROR Argument `str | None` is not assignable to parameter `language` with type `str` in function `services.account_service.AccountService.send_email_register_email` [bad-argument-type]
- --> controllers/console/auth/email_register.py:83:108
+ --> controllers/console/auth/email_register.py:86:108
ERROR Object of class `MissingRouter` has no attribute `get` [missing-attribute]
--> controllers/console/init_validate.py:31:2
ERROR Object of class `MissingRouter` has no attribute `post` [missing-attribute]
@@ -1830,22 +1830,6 @@
--> tests/unit_tests/controllers/console/app/test_wraps.py:43:16
ERROR Cannot set item in `OrderedDict[str, bool | list[str] | str]` [unsupported-operation]
--> tests/unit_tests/controllers/console/app/workflow_draft_variables_test.py:137:47
-ERROR `None` is not subscriptable [unsupported-operation]
- --> tests/unit_tests/controllers/console/auth/test_login_logout.py:516:16
-ERROR `None` is not subscriptable [unsupported-operation]
- --> tests/unit_tests/controllers/console/auth/test_login_logout.py:543:16
-ERROR Object of class `tuple` has no attribute `json` [missing-attribute]
- --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:74:16
-ERROR Type `Response` is not iterable [not-iterable]
- --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:92:13
-ERROR Type `Response` is not iterable [not-iterable]
- --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:117:13
-ERROR Type `Response` is not iterable [not-iterable]
- --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:142:13
-ERROR Type `Response` is not iterable [not-iterable]
- --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:165:13
-ERROR Object of class `tuple` has no attribute `json` [missing-attribute]
- --> tests/unit_tests/controllers/console/auth/test_token_refresh.py:192:16
ERROR Object of class `BadRequest` has no attribute `data` [missing-attribute]
--> tests/unit_tests/controllers/console/datasets/test_datasets.py:1655:16
ERROR Object of class `BytesIO` has no attribute `filename` [missing-attribute]
|
Contributor
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36331 +/- ##
==========================================
+ Coverage 85.94% 85.97% +0.02%
==========================================
Files 4454 4455 +1
Lines 211503 211858 +355
Branches 39515 39521 +6
==========================================
+ Hits 181782 182143 +361
+ Misses 26509 26503 -6
Partials 3212 3212
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asukaminato0721
previously approved these changes
May 18, 2026
…e-readiness # Conflicts: # packages/contracts/README.md # packages/contracts/generated/api/readiness.json
…' into codex/contracts-simple-readiness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
close #36330
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods