feat: app list for onboard#36329
Draft
hjlarry wants to merge 2 commits into
Draft
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-05-18 08:46:31.754584552 +0000
+++ /tmp/pyrefly_pr.txt 2026-05-18 08:46:24.591520946 +0000
@@ -558,6 +558,8 @@
--> services/document_indexing_proxy/duplicate_document_indexing_task_proxy.py:15:5
ERROR `handled_tenant_count` was assigned in the current scope before the nonlocal declaration [unknown-name]
--> services/plugin/plugin_migration.py:92:34
+ERROR Returned type `Sequence[RecommendedApp]` is not assignable to declared return type `list[RecommendedApp]` [bad-return]
+ --> services/recommend_app/database/database_retrieval.py:94:16
ERROR `dict[str, Any]` is not assignable to attribute `credentials` with type `Never` [bad-assignment]
--> services/trigger/trigger_provider_service.py:487:40
ERROR `int` is not assignable to attribute `credential_expires_at` with type `Never` [bad-assignment]
|
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
make lint && make type-check(backend) andcd web && pnpm exec vp staged(frontend) to appease the lint gods