-
Notifications
You must be signed in to change notification settings - Fork 303
fix(langchain): extract model name for ChatHuggingFace #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hassiebp
merged 2 commits into
langfuse:main
from
vismaytiwari:fix-langchain-chathuggingface-model
Jun 29, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| """Unit tests for langfuse.langchain.utils model-name extraction.""" | ||
|
|
||
| import pytest | ||
|
|
||
| from langfuse.langchain.utils import _extract_model_name | ||
|
|
||
| _MODEL_ID = "Qwen/Qwen2.5-Coder-32B-Instruct" | ||
|
|
||
|
|
||
| def _chat_huggingface_serialized(inner_repr: str) -> dict: | ||
| """Mirror ``langchain_core.load.dumpd(ChatHuggingFace(...))``. | ||
|
|
||
| ChatHuggingFace is not LangChain-serializable, so it serializes to a | ||
| ``not_implemented`` stub with no ``kwargs``; the model id is only available | ||
| inside the ``repr`` string as ``model_id='...'``. | ||
| """ | ||
| return { | ||
| "lc": 1, | ||
| "type": "not_implemented", | ||
| "id": [ | ||
| "langchain_huggingface", | ||
| "chat_models", | ||
| "huggingface", | ||
| "ChatHuggingFace", | ||
| ], | ||
| "repr": f"ChatHuggingFace(llm={inner_repr}, model_id='{_MODEL_ID}')", | ||
| "name": "ChatHuggingFace", | ||
| } | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "inner_repr", | ||
| [ | ||
| f"HuggingFaceEndpoint(repo_id='{_MODEL_ID}', model='{_MODEL_ID}', task='text-generation')", | ||
| f"HuggingFaceHub(repo_id='{_MODEL_ID}')", | ||
| # HuggingFacePipeline exposes its own model_id, so the repr carries two | ||
| # model_id='...' occurrences; re.search picks the first (inner) one. | ||
| f"HuggingFacePipeline(model_id='{_MODEL_ID}')", | ||
| ], | ||
| ) | ||
| def test_extract_model_name_chat_huggingface(inner_repr: str): | ||
| serialized = _chat_huggingface_serialized(inner_repr) | ||
|
|
||
| assert _extract_model_name(serialized) == _MODEL_ID | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.