Skip to content

fix: Compare versions in the right order so that lando setup is run if it is set and we are >= 3.24 and the -slim versions do not exist anymore #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
florianPat wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Compare versions in the right order so that lando setup is run if it is set and we are >= 3.24 and the -slim versions do not exist anymore #108

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b88179
fix: Compare versions in the right order so that lando setup is run i…
florianPat Jan 2, 2026
991bf22
Merge branch 'main' into slim-fix
pirog Jan 2, 2026
4309381
Merge branch 'main' into slim-fix
AaronFeledy Jan 3, 2026
e39d8f4
Merge branch 'main' into slim-fix
AaronFeledy Jan 10, 2026
c3e052f
fix: test URL construction (-slim suffix) not setup enable/disable
AaronFeledy Jan 10, 2026
44dd8ae
fix: use 3.24 threshold instead of 3.23.999 (version_compare ignores …
AaronFeledy Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions setup-lando.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,10 +594,10 @@ else
fi

# fatty slim
SLIM_SETUPY=$(version_compare "3.23.0" "$SVERSION" && echo '1' || echo '0')
SLIM_SETUPY=$(version_compare "$SVERSION" "3.23.999" && echo '1' || echo '0')
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated

# autoslim all v3 urls by default
if [[ $URL != file://* ]] && [[ -z "${VERSION_DEV-}" ]] && [[ $FAT != '1' ]] && [[ $SLIM_SETUPY == '1' ]]; then
if [[ $URL != file://* ]] && [[ -z "${VERSION_DEV-}" ]] && [[ $FAT != '1' ]] && [[ $SLIM_SETUPY == '0' ]]; then
URL="${URL}-slim"
HRV="$VERSION-slim"
debug "autoslimin url for lando 3 to $URL"
Expand Down
Loading