test: make V2 smoke test copy-out-and-run (.mjs, plain node) - #73
Merged
Conversation
The smoke test was a .ts that only ran via the repo's ts-node (yarn tsn) — a QA person who just `npm install github:...`'d the package couldn't run it without adding a TS toolchain. Convert it to plain ESM JavaScript so it works like ade-python's: install the package, drop the file into any project, and `node v2_smoke_test.mjs`. Runtime logic is unchanged (types stripped); typing is still covered by the SDK's tsc + jest + shipped .d.ts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
Consumer-install validation ✅Simulated a real consumer in a fresh project (not the repo checkout):
Real staging round-trips — confirms the copy-out-and-run flow works with plain Note: the built entrypoint installs at the package root ( 🤖 Generated with Claude Code |
yzld2002
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #72. The V2 smoke test was a
.tsrunnable only via the repo'syarn tsn(ts-node). A QA person who justnpm install github:landing-ai/ade-typescript#...'d the package into their own project couldn't run it without adding a TypeScript toolchain (ts-node/tsx + tsconfig).This converts
examples/v2_smoke_test.ts→examples/v2_smoke_test.mjs(plain ESM JavaScript), so it mirrors ade-python'sexamples/v2_smoke_test.py: install the package, drop the file into any project, andnode v2_smoke_test.mjs— no TS toolchain, no repo checkout.import LandingAIADE from 'landingai-ade'default-import pattern the built package already ships for V1 users.tsc(CI), the jest suite, and the shipped.d.ts..tsversion (identical logic) passed 7/7 live againstapi.ade.stagingin feat: V2 parse & extract SDK support (client.v2) #72.🤖 Generated with Claude Code