Skip to content

ci(spec-sync): scope the 504 timeout remediation per endpoint in the wiring prompt #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tian-lan-landing merged 2 commits into from
Jul 24, 2026
Merged

ci(spec-sync): scope the 504 timeout remediation per endpoint in the wiring prompt #130

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c0fc35
ci(spec-sync): tell the wiring prompt to scope the 504 remediation pe…
tian-lan-landing Jul 24, 2026
b4a6e74
Potential fix for pull request finding
tian-lan-landing Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/spec-sync.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,11 @@ jobs:

- Add a resource module under src/landingai_ade/resources/v2/ with a sync run()
(multipart or JSON per the spec; route a 504 through
lib/v2_errors.raise_if_sync_timeout) and, for an async route, a *JobsResource with
lib/v2_errors.raise_if_sync_timeout, passing THIS endpoint's own async route as
`jobs_resource` — e.g. `build_schema_jobs` — so the 504 remediation names the right
resource; never let it fall back to a parse/extract-specific message, and if the
helper doesn't yet take a per-endpoint `jobs_resource`, extend it rather than reusing
another endpoint's wording) and, for an async route, a *JobsResource with
Comment thread
Copilot marked this conversation as resolved.
Outdated
create / get / wait / list. Decide multipart-vs-JSON from the SPEC, not from a
generated class name: an operation accepts file uploads iff its
`requestBody.content` has a `multipart/form-data` variant with a property (or array
Expand Down