Add symlinks to license files#855
Merged
Merged
Conversation
Pat-Lafon
requested review from
dburgener,
nikomatsakis,
yannham and
youknowone
dburgener
approved these changes
Nov 14, 2023
Contributor
|
I read the associated links, and it seems like this is the right thing to do. Ideally, cargo would have support for copying this automatically, but since they've opted against doing that, it seems like this is what we need to do in order to meet our obligations under the apache and MIT licenses. The biggest problem with duplication in software repos IMO is the risk of missing a copy when changing things. In the case of symlinks, this is only a problem if we move or rename our license files, which I imagine is something that would happen very infrequently. |
This was referenced Apr 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #600
I don't fully understand the license implications here but from my reading, the correct solution from cargo has not fully manifested yet. In looking what other projects like tokio/regex do, they include the license files in each project so it seems reasonable to follow that strategy.
See bytecodealliance/wasmtime#4664 tokio-rs/tracing#842 rust-lang/cargo#8537 for some discussion on these issues.