governance(v21): authorize Windows npm execution policy repair - #380
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request adds a governance authorization document for repairing delegated npm execution on Windows. It defines scope, implementation constraints, validation requirements, merge rules, and restrictions on release and promotion actions. Changesnpm Windows execution authorization
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR only authorizes a narrowly scoped future Windows repair and does not change executable runtime behavior or production access. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Work package
V21-DELEGATED-NPM-WINDOWS-EXEC-POLICYGeneric base-owned governance repair authorization only. No Learned Policy product/runtime implementation is included.
Proven root cause
While validating Learned Policy PR #379 on Windows, the repository's generic delegated npm-lock topology policy failed before npm could start:
shared/release/implementationBranchPolicy.jsselectsnpm.cmdonwin32.cmdshim directly tochild_process.execFileSyncEINVAL, errno-4071c5b7d23dcd6a7aafef6f1b8749369ab008606c8breproduces the same three positive dependency-policy fixture failures: 0 pass / 3 failNo #379 scope expansion or product exception is permitted.
Exact authorization identity
c5b7d23dcd6a7aafef6f1b8749369ab008606c8bgovernance/v21-delegated-npm-windows-exec-policy-authorization76c9aeb3a2606b68c3f30a42190232d729ff66b3Future implementation seal
Future implementation branch, only after ordinary authorization merge:
fix/v21-delegated-npm-windows-exec-policyExactly two paths:
shared/release/implementationBranchPolicy.jstests/wp0/v21-delegated-dependency-policy.test.jsCanonical path-set SHA-256:
da9c824293effd3aa16d3837ba461b488ef62f20e806e18e5115ae42573e268bMandatory first implementation commit is test-only on:
tests/wp0/v21-delegated-dependency-policy.test.jsSingle-test path digest:
f0bd84f25ba0b97479477fc6d88d483833e66af32f720fe8aa1df948201ff1e2OSS-fit
Reuse existing Node.js
child_processand the repository's existing trusted process/policy seam. No second process runner, package-manager wrapper, workflow or dependency is authorized. The direct WindowsexecFileSync('npm.cmd', ...)path must be retired and replaced by a platform-correct trusted invocation while preserving static npm args, offline mode, timeout, stdout/status semantics and fail-closed topology checks.Boundaries
No temporary bypass, warning-only closure,
continue-on-error, test weakening, shell interpolation of untrusted data, network fallback, Learned Policy-specific exception, workflow/dependency change, rebase/amend/force-push/squash, release, publish or promotion.This authorization is effective only if ordinary two-parent merged while live
mainremains exactly the trusted base above. If main moves first, rebuild forward-only from fresh main.Summary by CodeRabbit