governance(acv2): authorize combined Schema 23 canonical migration closure - #376
Conversation
|
Warning Review limit reached
Next review available in: 71 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Work package
ACV2-SCHEMA23-CANONICAL-MIGRATION-COMBINED-CLOSURE-V2Fresh-main combined successor that resolves the real merge-order deadlock between PR #374's Schema 23 migration and #375's base-owned stale current-schema test contract.
Why a combined successor is required
ca72110604296a1a9ca3952757fc2ff24b779616has a real Schema 23 migration GREEN locally, but ACV2 CI is RED because base-owned tests still hard-code current total schema 22.bccd3145a4e885026414d50d61ad31121bdea709permits correcting those two tests, but a test-only implementation expecting current schema 23 cannot merge before the production migration exists.This successor therefore combines only the already-audited five exact paths into one atomic failure-first work package.
Exact implementation scope
Five paths, SHA-256
787a88f19855e80d316d03622857d53f2fd654c4b50cd1641bc845b6d6a9edd8:backend/lib/r32SqliteStore.jsbackend/migrations/architectureClosureV2DomainEventProjectionJobsCanonical.jsbackend/tests/architectureClosureV2/wpA/authorityWriteHost.test.jsbackend/tests/architectureClosureV2/wpA/domainEventProjectionJobsCanonicalMigration.test.jsbackend/tests/batch27DeveloperHandoffV2Closure.test.jsMandatory first implementation commit is test-only on exactly the three test paths, SHA-256
fbda331336c0f09da7579f29a443b0de85fb573f3ccecd7983c09b11dde4725c, and must establish a fresh combined causal RED from current trusted main.The GREEN descendant may add only the two production paths already independently reviewed on #374.
Historical boundary
Historical Schema 22 migration identity, target and receipt remain exactly 22.
schema22PostMergeIntegrityMigration.test.jsis explicitly out of scope. Current total R32 schema advances to 23 only with the new forward migration.No dependencies, workflows, package/lock files, projection worker changes, history rewrites, rebase, cherry-pick-as-authority, release, publish or gate weakening.
Learned Policy isolation
PR #372 remains frozen at
fb1beeb0e39ad4d6263f71b4c995eb5ec663e6e2until this combined closure ordinary-merges.