feat(FR-2573): migrate /data and /admin-data pages to V2 vfolder queries#6704
Draft
ironAiken2 wants to merge 1 commit intomainfrom
Draft
Conversation
Resolves #6689(FR-2573) Phase 1 of FR-2573. Migrates /data (VFolderListPage) and /admin-data (AdminVFolderListPage) from the legacy vfolder_nodes Graphene query to the Strawberry V2 API (myVfolders, adminVfoldersV2) with typed VFolder structure (metadata/accessControl/ownership), VFolderFilter/VFolderOrderBy inputs, and V2 bulk mutations for delete/purge. Per issue constraint, legacy components are left untouched. New parallel sibling components were created and only routes.tsx was swapped: - VFolderListPage, AdminVFolderListPage (new pages) - VFolderList (replaces VFolderNodes table) - VFolderDeleteModalV2 (bulkDeleteVfoldersV2) - VFolderRestoreModalV2 (REST restore_from_trash_bin; see FIXMEs) - VFolderSharedPermissionInfoModalV2 - VFolderPermissionCellV2, VFolderIdenticonV2 - vfolderFilters helper (usage mode / status category presets) Phase 1 FIXMEs (Phase 2 backend work): - num_files/cur_size/max_files/max_size hidden columns render '-' until VFolderMetadataInfo exposes them. - Restore flow stays on REST until restoreVfolderV2 exists. - leave_invited stays on REST until V2 equivalent exists. - myVfolders project/shared folder coverage needs runtime verification; if incomplete, compose with projectVfolders in a follow-up. Spec: .specs/FR-2573-data-page-api/data-page-api-analysis.md
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.64% (-0.15% 🔻) |
1735/20091 |
| 🔴 | Branches | 7.85% (-0.15% 🔻) |
1097/13981 |
| 🔴 | Functions | 5.18% (-0.11% 🔻) |
283/5467 |
| 🔴 | Lines | 8.34% (-0.15% 🔻) |
1627/19517 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / vfolderFilters.ts |
0% | 0% | 0% | 0% |
| 🔴 | ... / VFolderDeleteModalV2.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / VFolderIdenticonV2.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / VFolderList.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / VFolderPermissionCellV2.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / VFolderRestoreModalV2.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / VFolderSharedPermissionInfoModalV2.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / AdminVFolderListPage.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / VFolderListPage.tsx |
0% | 0% | 0% | 0% |
Test suite run success
847 tests passing in 38 suites.
Report generated by 🧪jest coverage report action from 4c0e7b4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #NNN (FR-MMM)
Checklist: (if applicable)