Skip to content

chore(FR-2559): fix template injection and compile watchdog with gh-aw v0.68.1#6690

Closed
nowgnuesLee wants to merge 1 commit into04-14-feat_fr-2559_add_teams_notification_jira_integration_and_result_parsing_to_e2e-watchdogfrom
04-14-chore_fr-2559_fix_template_injection_and_compile_watchdog_with_gh-aw_v0.68.1
Closed

chore(FR-2559): fix template injection and compile watchdog with gh-aw v0.68.1#6690
nowgnuesLee wants to merge 1 commit into04-14-feat_fr-2559_add_teams_notification_jira_integration_and_result_parsing_to_e2e-watchdogfrom
04-14-chore_fr-2559_fix_template_injection_and_compile_watchdog_with_gh-aw_v0.68.1

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

resolves #NNN (FR-MMM)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

…w v0.68.1

- Fix template injection vulnerabilities: move ${{ }} expressions
  to env: vars in Run E2E tests, Parse results, Send Teams notification,
  Create/Resolve Jira issue steps
- Fix YAML parsing error: replace multi-line DESC heredoc with printf
- Move password secrets from global env: to step-level env: on test step
- Add strict: false frontmatter to allow secrets in pre-agent steps
- Compile e2e-watchdog.lock.yml with gh-aw v0.68.1

Resolves compilation blocker for FR-2559 stack
Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee
Copy link
Copy Markdown
Contributor Author

Superseded by commit 1ef738b on PR #6666 (cherry-picked directly onto the watchdog branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant