Skip to content

Update go.yml #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franchb merged 4 commits into from
Nov 6, 2025
Merged

Update go.yml #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a85024d
Update go.yml
franchb Nov 6, 2025
5eed726
Update release.yml
franchb Nov 6, 2025
468e14e
migrate to golangci-lint v2
franchb Nov 6, 2025
2ed40e1
fix: govet
franchb Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v6
with:
go-version: 1.24.2
go-version: 1.25.3
id: go
- name: Check out code
uses: actions/checkout@v5
Expand All @@ -31,15 +31,15 @@ jobs:
- name: "Set up Go"
uses: actions/setup-go@v6
with:
go-version: 1.24.2
go-version: 1.25.3
id: go
- name: Check out code
uses: actions/checkout@v5
- name: Lint
uses: golangci/golangci-lint-action@v8
with:
version: v1.64.5
args: --config ./.golangci.yml --timeout=5m
version: v2.6.0
args: --config ./.golangci.yml --timeout=5m --tests=false
test:
name: Test ${{ matrix.os }}
needs: Lint
Expand All @@ -51,7 +51,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v6
with:
go-version: 1.24.2
go-version: 1.25.3
id: go
- name: Check out code
uses: actions/checkout@v5
Expand All @@ -68,7 +68,7 @@ jobs:
- name: Set up Go ${{ matrix.go-version }}
uses: actions/setup-go@v6
with:
go-version: 1.24.2
go-version: 1.25.3
- name: Check out code into the Go module directory
uses: actions/checkout@v5
- name: Get govulncheck
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v6
with:
go-version: 1.24.0
go-version: 1.25.3

@coderabbitai coderabbitai Bot Nov 6, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify Go 1.25.3 is a valid release and all workflows are consistently updated.

The YAML syntax is correct, but ensure that:

  1. Go 1.25.3 is an actual, released version
  2. All other workflow files (e.g., .github/workflows/go.yml mentioned in the enriched summary) are also updated to Go 1.25.3 for consistency

Run this script to verify consistency across all workflow files:

Additionally, search for the latest Go version to confirm 1.25.3 is valid:

🏁 Script executed:

#!/bin/bash
# Description: Check all GitHub Actions workflows for Go version specifications

echo "=== Go version specifications in all workflows ==="
fd -e yml -e yaml . .github/workflows/ -x grep -n "go-version" {} +

echo ""
echo "=== Checking for version inconsistencies ==="
fd -e yml -e yaml . .github/workflows/ -x grep -h "go-version" {} + | sort | uniq -c

Length of output: 1089

🌐 Web query:

What is the latest version of Go and is 1.25.3 a valid release?

💡 Result:

The latest stable Go release (as of Nov 6, 2025) is go1.25.3 (released October 13, 2025). Yes — 1.25.3 is an official valid release. [1][2]

Sources:
[1] go.dev VERSION (go1.25.3, time 2025-10-13).
[2] Go release history / release notes (go1.25.3 released 2025-10-13).

Update go-ossf-slsa3-publish.yml to use Go 1.25.3 for consistency across workflows.

Go 1.25.3 is a valid release (released October 13, 2025), confirming the version choice is sound. However, the PR is incomplete: .github/workflows/go-ossf-slsa3-publish.yml at line 34 still specifies go-version: 1.17, while release.yml and go.yml have been updated to 1.25.3. This inconsistency should be resolved by updating that file to match the others.

🤖 Prompt for AI Agents 
In .github/workflows/go-ossf-slsa3-publish.yml around line 34, the job still
pins go-version: 1.17 while release.yml and go.yml use 1.25.3; update that
go-version value to 1.25.3 so all workflow files consistently use Go 1.25.3,
then run a quick CI/lint check to ensure the workflow YAML remains valid.

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
Expand Down
59 changes: 37 additions & 22 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,44 @@
linters-settings:
misspell:
locale: US

staticcheck:
checks: ["all", "-SA1019"]

version: "2"
linters:
disable-all: true
default: none
enable:
- typecheck
- goimports
- misspell
- staticcheck
- govet
- revive
- ineffassign
- gosimple
- unused
- misspell
- prealloc
- revive
- staticcheck
- unconvert
# TODO - gosec
- unused
settings:
misspell:
locale: US
staticcheck:
checks:
- all
- -SA1019
- -ST1000
exclusions:
generated: lax
rules:
- path: (.+)\.go$
text: 'var-naming: don''t use ALL_CAPS in Go names; use CamelCase'
- path: (.+)\.go$
text: 'package-comments: should have a package comment'
- path: (.+)\.go$
text: 'exitAfterDefer:'
paths:
- third_party$
- builtin$
- examples$
formatters:
enable:
- gofumpt

issues:
exclude-use-default: false
exclude:
- "var-naming: don't use ALL_CAPS in Go names; use CamelCase"
- "package-comments: should have a package comment"
- "exitAfterDefer:"
- goimports
exclusions:
generated: lax
paths:
- third_party$
- builtin$
- examples$
2 changes: 1 addition & 1 deletion cmd/kes/autocomplete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,5 +196,5 @@ func isCompletionInstalled(filename, autoloadCmd, completeCmd string) (autoload,
if err = file.Close(); err != nil {
cli.Fatal(err)
}
return
return autoload, complete
}
11 changes: 5 additions & 6 deletions cmd/kes/identity.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import (
"github.com/minio/kes/internal/cli"
"github.com/minio/kes/internal/https"
"github.com/minio/kms-go/kes"
sdk "github.com/minio/kms-go/kes"
flag "github.com/spf13/pflag"
"golang.org/x/term"
)
Expand Down Expand Up @@ -76,7 +75,7 @@ func identityCmd(args []string) {
}

if flags.NArg() == 0 {
key, err := sdk.GenerateAPIKey(nil)
key, err := kes.GenerateAPIKey(nil)
if err != nil {
cli.Exitf("failed to generate API key: %v", err)
}
Expand Down Expand Up @@ -107,7 +106,7 @@ func identityCmd(args []string) {
return
}

printIdentity := func(identity sdk.Identity) {
printIdentity := func(identity kes.Identity) {
if !cli.IsTerminal() {
fmt.Print(identity)
return
Expand All @@ -122,7 +121,7 @@ func identityCmd(args []string) {
fmt.Fprint(buf, "or certificate and can be shared securely.")
fmt.Println(tui.NewStyle().Border(tui.HiddenBorder()).Padding(0, 0, 0, 0).Render(buf.String()))
}
if key, err := sdk.ParseAPIKey(flags.Arg(0)); err == nil {
if key, err := kes.ParseAPIKey(flags.Arg(0)); err == nil {
printIdentity(key.Identity())
return
}
Expand All @@ -147,7 +146,7 @@ func identityCmd(args []string) {
cli.Exit(err)
}
h := sha256.Sum256(cert.RawSubjectPublicKeyInfo)
printIdentity(sdk.Identity(hex.EncodeToString(h[:])))
printIdentity(kes.Identity(hex.EncodeToString(h[:])))
return
case strings.Contains(block.Type, "PRIVATE KEY"): // Type may be PRIVATE KEY, EC PRIVATE KEY, ...
priv, err := x509.ParsePKCS8PrivateKey(block.Bytes)
Expand Down Expand Up @@ -330,7 +329,7 @@ func newIdentityCmd(args []string) {
if err = os.WriteFile(keyPath, keyPem, 0o600); err != nil {
cli.Fatalf("failed to create private key: %v", err)
}
if err = os.WriteFile(certPath, certPem, 0o644); err != nil {
if err = os.WriteFile(certPath, certPem, 0o600); err != nil {
os.Remove(keyPath)
cli.Fatalf("failed to create certificate: %v", err)
}
Expand Down
8 changes: 1 addition & 7 deletions cmd/kes/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ Commands:
status Print server status.
metric Print server metrics.

migrate Migrate KMS data.
update Update KES binary.

Options:
-v, --version Print version information.
--auto-completion Install auto-completion for this shell.
Expand All @@ -70,9 +67,6 @@ func main() {
"log": logCmd,
"status": statusCmd,
"metric": metricCmd,

"migrate": migrate,
"update": updateCmd,
}

if len(os.Args) < 2 {
Expand Down Expand Up @@ -241,7 +235,7 @@ func newClient(conf config) *kes.Client {
GetClientCertificate: func(*tls.CertificateRequestInfo) (*tls.Certificate, error) {
return &cert, nil
},
InsecureSkipVerify: conf.InsecureSkipVerify,
InsecureSkipVerify: false,
})
client.Endpoints = endpoints
return client
Expand Down
Loading
Loading