Alpha module list by anoipm · Pull Request #2884 · kyma-project/cli

anoipm · 2026-04-15T18:49:19Z

Description

Changes proposed in this pull request:

add (alpha/v2) module list command (without community modules - will be added in a follow-up PR),
improve json/yaml output:
- separate version and channel into distinct fields instead of concatenating them,
- correct managed type - managed is a boolean instead of a string.

Related issue(s)
See also:

[CLI modules v2] kyma alpha module list #2819

github-actions · 2026-04-15T18:52:36Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify / standards (pull_request_target) action.

github-actions · 2026-05-14T19:39:07Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

github-actions · 2026-05-14T20:58:13Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

musztardem · 2026-05-18T09:54:16Z

+	return &moduleInstallationStateRepository{kubeClient: kubeClient}
+}
+
+func (r *moduleInstallationStateRepository) GetInstallationState(ctx context.Context, module entities.ModuleInstallation) (string, error) {


This is implementation of a separate repository for a single string value that I believe should live in the ModuleInstallation as the installation state belongs to the moduleInstallation. I see however that there's lot of extraction logic that might bloat the original repository.

I think we could introduce some kind of extractors or converters package that could live in the repository package that could have specialized classes responsible for such data transformations

Refactored. Extracted extractStateFromObject as a function responsible for state interpretation.

musztardem · 2026-05-18T10:09:54Z

There's some discrepancy in how module list and alpha module list work for managed modules, there's output from my console:

$ ./bin/kyma alpha module list
MODULE                  VERSION               CR POLICY         MANAGED   MODULE STATUS   INSTALLATION STATUS
api-gateway             3.6.2(regular)        CreateAndDelete   true      Ready           Ready
application-connector   1.3.1(fast)           CreateAndDelete   true      Ready           Ready
btp-operator            1.3.2(regular)        CreateAndDelete   true      Ready           Ready
cap-operator            0.28.0(fast)          CreateAndDelete   true      Ready           Ready
cfapi                   0.4.0(experimental)   CreateAndDelete   true      Ready           Ready
cloud-manager           1.7.1(fast)           CreateAndDelete   true      Ready           Ready
connectivity-proxy      1.2.2(fast)           CreateAndDelete   true      Ready           Ready
eventing                1.5.3(fast)           CreateAndDelete   true      Deleting        Deleting
istio                   1.26.7(regular)       CreateAndDelete   true      Ready           Ready
keda                    1.10.1(fast)          CreateAndDelete   true      Ready           Ready
nats                    1.5.2(fast)           CreateAndDelete   true      Deleting        Deleting
serverless              1.12.0(fast)          CreateAndDelete   true      Ready           Ready
telemetry               1.63.3(fast)          CreateAndDelete   true      Ready           Ready
transparent-proxy       1.9.5(fast)           CreateAndDelete   true      Ready           Ready
ztis-agent              0.28.0(fast)          CreateAndDelete   true      Ready           Ready
[12:03:07] [cost 0.409s] ./bin/kyma alpha module list

$ ./bin/kyma module list
2026-05-18T10:05:11.442219Z	info	klog	Waited before sending request	delay=1.1237515s reason=client-side throttling, not priority and fairness verb=GET URL=https://api.ee0bdf1.stage.kyma.ondemand.com/apis/operator.kyma-project.io/v1beta2/namespaces/kyma-system/moduletemplates/istio-1.26.7
NAME                    VERSION               CR POLICY         MANAGED   MODULE STATUS   INSTALLATION STATUS
api-gateway             3.6.2(regular)        CreateAndDelete   true      Ready           Ready
application-connector   1.3.1(fast)           CreateAndDelete   true      Ready           Ready
btp-operator            1.3.2(regular)        CreateAndDelete   true      Ready           Ready
cap-operator            0.28.0(fast)          CreateAndDelete   true      Ready           Ready
cfapi                   0.4.0(experimental)   CreateAndDelete   true      Ready           Ready
cloud-manager           1.7.1(fast)           CreateAndDelete   true      Ready           Ready
connectivity-proxy      1.2.2(fast)           CreateAndDelete   true      Ready           Ready
eventing                1.5.3(fast)           CreateAndDelete   true                      Deleting
istio                   1.26.7(regular)       CreateAndDelete   true      Warning         Ready
keda                    1.10.1(fast)          CreateAndDelete   true      Warning         Ready
nats                    1.5.2(fast)           CreateAndDelete   true      Warning         Deleting
serverless              1.12.0(fast)          CreateAndDelete   true      Ready           Ready
telemetry               1.63.3(fast)          CreateAndDelete   true      Ready           Ready
transparent-proxy       1.9.5(fast)           CreateAndDelete   true      Ready           Ready
ztis-agent              0.28.0(fast)          CreateAndDelete   true      Error           Ready
docker-registry         0.13.0                N/A               false     Ready           Ready
registry-proxy          0.14.0                N/A               false     Ready           Ready
[12:05:16] [cost 7.593s] ./bin/kyma module list

github-actions · 2026-05-19T20:29:14Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

github-actions · 2026-05-27T10:41:09Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

github-actions · 2026-05-27T11:05:18Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

github-actions · 2026-05-28T15:30:48Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

…uleInstallation

…solveInstallationState

…sitory

…duleState field

…lify ListService

github-actions · 2026-05-28T18:28:46Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

…llFields

github-actions · 2026-05-28T18:38:32Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

github-actions · 2026-05-28T18:53:15Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

github-actions · 2026-05-28T19:00:18Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

musztardem · 2026-06-01T10:39:04Z

+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+)
+
+type ModuleCRStateRepository interface {


I think this class and moduleInstallationState repositories should be a part of ModuleInstallationRepository because they're technically not repositories - repositories are tightly related to some entity and manage their lifecycles:

ModuleInstallationEntity is managed by ModuleInstallationRepository - get/list/create/update/delete

Done. ModuleCRStateRepository and ModuleInstallationStateRepository are now internal implementation details of ModuleInstallationsRepository

musztardem · 2026-06-01T10:41:39Z

+	"github.com/kyma-project/cli.v3/internal/modulesv2/entities"
+)
+
+type InstalledModulesRepository interface {


I think the repository naming should reflect an association with the entity it's related to, so I would see it as ModuleInstallationsRepository

Done — renamed to ModuleInstallationsRepository.

github-actions · 2026-06-01T13:14:13Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

…tory

github-actions · 2026-06-02T11:24:34Z

✅ Proposed changes verification passed

This pull request comes with up-to-date documentation and no illegal standard output usages.

Find more detailed information in the verify-pr-code / standards action.

anoipm added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2026

anoipm requested a review from a team as a code owner April 15, 2026 18:49

anoipm requested a review from a team as a code owner April 15, 2026 19:07

musztardem reviewed Apr 21, 2026

View reviewed changes

Comment thread internal/modulesv2/repository/installedmodules.go Outdated

musztardem reviewed Apr 21, 2026

View reviewed changes

Comment thread internal/modulesv2/repository/moduleinstallationstate.go Outdated

musztardem reviewed Apr 21, 2026

View reviewed changes

Comment thread internal/modulesv2/list.go Outdated

anoipm force-pushed the alpha-module-list branch from 7e24e9e to f8c347b Compare May 14, 2026 20:57

musztardem reviewed May 15, 2026

View reviewed changes

Comment thread internal/modulesv2/repository/installedmodules.go Outdated

anoipm removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2026

musztardem self-assigned this May 18, 2026

musztardem reviewed May 18, 2026

View reviewed changes

Comment thread internal/modulesv2/list.go Outdated

musztardem reviewed May 18, 2026

View reviewed changes

anoipm assigned anoipm and unassigned musztardem May 20, 2026

anoipm added 8 commits May 28, 2026 20:27

add kyma alpha module list stub

faea536

add under construction note to list cmd help

50f4c34

add ListService with InstalledModulesRepository

93a81fe

ListService returns core modules from InstalledModulesRepository

576166c

wire ListService to list command, print module names

915f7be

add version and channel to ListResult

b730589

render list as table with module, version, channel columns

a5b049a

update generated docs for alpha module list

9b233bc

anoipm added 15 commits May 28, 2026 20:27

update list command description

d63eb36

align JSON/YAML keys with column names

495ff86

rename State to ModuleState in ListResult

1bce140

introduce ModuleInstallation entity, move business logic to service

f3f99ce

replace Template field with TemplateName and TemplateNamespace in Mod…

586fb9a

…uleInstallation

merge spec and status when listing installed modules

8837a90

add IsBeingDeleted to ModuleInstallation, handle deleting state in re…

2a09ad0

…solveInstallationState

add ModuleCRStateRepository to fetch module state from CR

b74b12b

handle unmanaged modules in ModuleCRStateRepository

c468580

log discovery errors instead of propagating them in ModuleCRStateRepo…

59d5cbb

…sitory

simplify installationStatus rendering - show InstallationState directly

5988462

extract extractStateFromObject, reuse in highestStateFromList

85496de

move state extraction helpers to stateextractor.go

f03c7d1

move ModuleCRState fetching to InstalledModulesRepository, add KymaMo…

4197537

…duleState field

move installationState resolution to InstalledModulesRepository, simp…

3569a13

…lify ListService

anoipm force-pushed the alpha-module-list branch from 161df3f to 3569a13 Compare May 28, 2026 18:28

anoipm added 2 commits May 28, 2026 20:35

simplify tests: remove trivial field-mapping tests, consolidate MapsA…

f634267

…llFields

fix gofmt formatting in modulecrstate.go

a786495

anoipm assigned musztardem and unassigned anoipm May 28, 2026

musztardem reviewed Jun 1, 2026

View reviewed changes

rename InstalledModulesRepository to ModuleInstallationsRepository

5d58886

internalize ModuleCRStateRepository and ModuleInstallationStateReposi…

d9144dd

…tory

Conversation

anoipm commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Proposed changes verification passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 14, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 14, 2026

✅ Proposed changes verification passed

Uh oh!

Uh oh!

Uh oh!

musztardem May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anoipm May 27, 2026

Choose a reason for hiding this comment

Uh oh!

musztardem commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 27, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 27, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 28, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 28, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 28, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 28, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented May 28, 2026

✅ Proposed changes verification passed

Uh oh!

musztardem Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

anoipm Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

musztardem Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

anoipm Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 1, 2026

✅ Proposed changes verification passed

Uh oh!

github-actions Bot commented Jun 2, 2026

✅ Proposed changes verification passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anoipm commented Apr 15, 2026 •

edited

Loading

github-actions Bot commented Apr 15, 2026 •

edited

Loading

musztardem May 18, 2026 •

edited

Loading

musztardem commented May 18, 2026 •

edited

Loading