Skip to content

[Store] Fix source refcnt leak in CopyEnd/MoveEnd on invalid source #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
he-yufeng wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

[Store] Fix source refcnt leak in CopyEnd/MoveEnd on invalid source #2628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions mooncake-store/src/master_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3497,6 +3497,12 @@ tl::expected<void, ErrorCode> MasterService::CopyEnd(
LOG(ERROR) << "key=" << key << ", source_id=" << source_id
<< ", status=" << (source == nullptr ? "nullptr" : "invalid")
<< ", copy source becomes invalid during data transfer";
// Release the refcnt taken in CopyStart. The success path below does
// this once the copy completes; this error path must do it too, or the
// source replica stays pinned and can never be evicted.
if (source != nullptr) {
source->dec_refcnt();
}
// Discard target replicas and clear the replication task.
EraseReplicasWithCacheTotalAccounting(
metadata, [&task](const Replica& replica) {
Expand Down Expand Up @@ -3724,6 +3730,12 @@ tl::expected<void, ErrorCode> MasterService::MoveEnd(
LOG(ERROR) << "key=" << key << ", source_id=" << source_id
<< ", status=" << (source == nullptr ? "nullptr" : "invalid")
<< ", move source becomes invalid during data transfer";
// Release the refcnt taken in MoveStart. The success path below does
// this once the move completes; this error path must do it too, or the
// source replica stays pinned and can never be evicted.
if (source != nullptr) {
source->dec_refcnt();
}
// Discard target replica and clear the replication task.
EraseReplicasWithCacheTotalAccounting(
metadata, [&task](const Replica& replica) {
Expand Down
Loading