Skip to content

fix: make StableID unique to prevent duplicate key errors#144

Closed
khoben wants to merge 1 commit intokutovoys:mainfrom
khoben:fix/stable-id-duplicates
Closed

fix: make StableID unique to prevent duplicate key errors#144
khoben wants to merge 1 commit intokutovoys:mainfrom
khoben:fix/stable-id-duplicates

Conversation

@khoben
Copy link
Copy Markdown

@khoben khoben commented Apr 9, 2026

Adds Name and Index to the StableID computation.

This fixes duplicate :key warnings and the Cannot read properties of undefined (reading 'after') error in Alpine.js when multiple proxies have very similar or identical configurations.

Description of Changes

  • Improved GenerateStableID() method to include proxy Name and Index
  • Eliminates duplicate key errors in the frontend

Type of Changes

  • Bug fix
  • New feature
  • Documentation improvement
  • Performance optimization
  • Other

Related Issues

#141

Checklist

  • I have performed a self-review of my code
  • I have tested changes locally
  • I have made corresponding changes to the documentation (not needed)

Adds Name and Index to the `StableID` computation

Closes #141
@kutovoys
Copy link
Copy Markdown
Owner

kutovoys commented Apr 9, 2026

Спасибо, но я отклоню ПР по двум причинам:

  1. Нельзя использовать Index для построения stableID. Иначе при изменении порядка конфигов в подписке - будет менятся и stableID.
  2. Есть другой ПР, в котором это фиксится.

@kutovoys kutovoys closed this Apr 9, 2026
@khoben
Copy link
Copy Markdown
Author

khoben commented Apr 9, 2026

Хорошо, без проблем.
Думаю вообще проще изначально саму строку подключения хэшировать и брать за stableId. При обработке списка хэш-дубли удалять

@khoben khoben deleted the fix/stable-id-duplicates branch April 9, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants