feat(bin): scaffold jj bookmark branch step for jj-managed projects - #1945
feat(bin): scaffold jj bookmark branch step for jj-managed projects#1945swissgrammie wants to merge 4 commits into
Conversation
fm-brief.sh now reads the home registry's `jj` token (after the mode bracket) and, when present, emits `jj bookmark create fm/<id>` as the ship brief's branch step instead of `git checkout -b`. Projects without the token keep the existing git step byte-identically; the scout and secondmate variants are untouched.
5fbafa0 to
a8d5a28
Compare
Confidence Score: 4/5The PR is not yet safe to merge because a generated jj brief can still mandate a command unavailable in the worker environment. The new check validates firstmate's scaffold-time PATH, while the worker runs in a pane owned by a daemon that does not inherit that environment, leaving the previously reported execution-time availability failure reachable. Files Needing Attention: bin/fm-brief.sh Reviews (3): Last reviewed commit: "no-mistakes: apply CI fixes" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| [ "$JJ_TOKEN" = jj ] && JJ_MANAGED=1 | ||
| fi | ||
| if [ "$JJ_MANAGED" = 1 ]; then | ||
| if command -v jj >/dev/null 2>&1 && command -v jjhouse >/dev/null 2>&1; then |
There was a problem hiding this comment.
If firstmate's PATH contains jj and jjhouse but the long-lived worker daemon's PATH lacks jj, this check emits jj bookmark create even though the worker pane cannot execute it, causing the mandatory first action to fail before task work begins.
1 participant
Enables Jujutsu (jj) support in firstmate: ship briefs scaffold the jj bookmark branch step when a project is jj-marked.
Takes effect only when jj has been selected for a project and jjhouse is installed. All other projects (treehouse/git) keep the existing workflow, byte-identical.
Updates from git push no-mistakes