Skip to content

feature: add media param on generate push notif url #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zipzap11 merged 4 commits into from
Jun 26, 2026
Merged

feature: add media param on generate push notif url #81

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59d9623
feature: add media param on generate push notif url
Jun 25, 2026
97f783e
tidy up
Jun 26, 2026
5d87765
bump: update changelog
Jun 26, 2026
62e0b96
fix
Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,22 @@
# go-utils

<a name="v1.49.0"></a>
## [v1.49.0] - 2026-06-26
### New Features
- add media param on generate push notif url


<a name="v1.48.0"></a>
## [v1.48.0] - 2026-06-22
## [v1.48.0] - 2026-06-24
### New Features
- contains prefix
- contains prefix ([#80](https://github.com/kumparan/go-utils/issues/80))


<a name="v1.47.0"></a>
## [v1.47.0] - 2026-05-13
### New Features
- prevent duplicate punctuation on paragraph ending
- prevent duplicate punctuation on paragraph ending


<a name="v1.46.0"></a>
Expand Down Expand Up @@ -429,7 +436,8 @@
- init go-utils


[Unreleased]: https://github.com/kumparan/go-utils/compare/v1.48.0...HEAD
[Unreleased]: https://github.com/kumparan/go-utils/compare/v1.49.0...HEAD
[v1.49.0]: https://github.com/kumparan/go-utils/compare/v1.48.0...v1.49.0
[v1.48.0]: https://github.com/kumparan/go-utils/compare/v1.47.0...v1.48.0
[v1.47.0]: https://github.com/kumparan/go-utils/compare/v1.46.0...v1.47.0
[v1.46.0]: https://github.com/kumparan/go-utils/compare/v1.45.0...v1.46.0
Expand Down
6 changes: 3 additions & 3 deletions media.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const (

// GeneratePushNotificationMediaURL Generates manipulated media URL for push notification purpose
// e.g. GeneratePushNotificationMediaURL("http://mycdn.com", "http://my.image.com/image/upload/v123/image.jpg", LargeIcon) => http://mycdn.com/image/upload/v123/image.jpg
func GeneratePushNotificationMediaURL(cdnURL, mediaSrcURL, imageType string) string {
func GeneratePushNotificationMediaURL(cdnURL, mediaSrcURL, imageType, additionalParam string) string {
if mediaSrcURL == "" || cdnURL == "" {
return ""
}
Expand All @@ -36,7 +36,7 @@ func GeneratePushNotificationMediaURL(cdnURL, mediaSrcURL, imageType string) str
param = "image/upload/fl_progressive,fl_lossy,c_fill,g_face,q_auto:best,w_1024,h_1024,f_jpeg"
}

mediaURL := cdnURL + "/" + param + "/" + coverMediaFile
mediaURL := cdnURL + "/" + param + "/" + coverMediaFile + additionalParam

return mediaURL
return mediaURL + ""
}
Loading