Fix cluster quota handler registration

[vishnubijukumar]

What this PR does / why we need it:
Fail fast when cluster quota controller event handler registration fails, instead of silently continuing with a partially initialized controller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
This updates the CRQ and AACRQ controller constructors to stop ignoring informer handler registration errors.
It also adds focused constructor tests for both controllers and fixes adjacent Infof usage in the touched files so the package tests pass.

Release note:

NONE

[kubevirt-prow]

Hi @vishnubijukumar. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubevirt-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign barakmor1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Hey - I've left some high level feedback:

• Instead of panicking with a fixed string in the controller constructors, consider including the underlying error in the panic message (or returning it) to aid debugging when handler registration fails.
• The erroringSharedIndexInformer test helper is duplicated in both constructor test files; consider moving it into a shared test utility to avoid repetition and keep behavior consistent.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Instead of panicking with a fixed string in the controller constructors, consider including the underlying error in the panic message (or returning it) to aid debugging when handler registration fails.
- The `erroringSharedIndexInformer` test helper is duplicated in both constructor test files; consider moving it into a shared test utility to avoid repetition and keep behavior consistent.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}