Correct the usage of kubevirtci - #122
Conversation
kubevirt-bot
added
release-note-none
|
Update: Had to remove the Target var from the lane yaml definition : /test pull-aaq-functest |
b065171 to
4ff5f3c
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
Signed-off-by: bmordeha <bmordeha@redhat.com>
1b75b66 to
c2838c5
Compare
enp0s3
left a comment
enp0s3
left a comment
There was a problem hiding this comment.
@Barakmor1 Looks great! I've found some micro nits, please see below, other than that LGTM
| fi | ||
| } | ||
|
|
||
|
|
| # Required for kubevirtci_git_hash | ||
| source $(dirname "$0")/config.sh | ||
|
|
||
| WASP_DIR="$( |
There was a problem hiding this comment.
| WASP_DIR="$( | |
| AAQ_DIR="$( |
| download_cluster_up=true | ||
| function getClusterUpShasum() { | ||
| ( | ||
| cd ${WASP_DIR} |
There was a problem hiding this comment.
| cd ${WASP_DIR} | |
| cd ${AAQ_DIR} |
Signed-off-by: bmordeha <bmordeha@redhat.com>
Signed-off-by: bmordeha <bmordeha@redhat.com>
Signed-off-by: bmordeha <bmordeha@redhat.com>
added scripts in hack directory to comply with kubevirtci dependencies Signed-off-by: bmordeha <bmordeha@redhat.com>
kubevirt deployment moved to cluster-up in a not autogenerated ./hack/cluster-up.sh file. sync.sh clean.sh install.sh are now working with kubevirtci. KUBEVIRT_RELEASE is now defined in config-kubevirtci.sh fixed default image url for make manifests its now the internal registry URL of kubevirtci. Signed-off-by: bmordeha <bmordeha@redhat.com>
Signed-off-by: bmordeha <bmordeha@redhat.com>
Without setting it we violates PodSecurity "restricted:latest" Includeing the sidecar container for plugable policies in the function tests Since k8s > version 1.30 Signed-off-by: bmordeha <bmordeha@redhat.com>
Signed-off-by: bmordeha <bmordeha@redhat.com>
Signed-off-by: bmordeha <bmordeha@redhat.com>
Signed-off-by: bmordeha <bmordeha@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Barakmor1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherrypick release-v1.3 |
|
@Barakmor1: new pull request created: #123 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
What this PR does / why we need it:
Instead of copying the content from kubevirtci and adding the KubeVirt installation to make cluster-up, include the relevant kubevirtci content in AAQ and make the KubeVirt installation part of the make cluster-up as a seperated process from the imported kubevirtci process.
This PR was inspired by @enp0s3 work in here
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: