[quality] Add handler test helper and health/status endpoint tests

[clubanderson]

Test Improvement

Introduces newHandlerTestServer() — a lightweight Server constructor for HTTP handler unit tests that requires no external dependencies (no kubeconfig, no k8s cluster, no AI providers).

Test Helper (newHandlerTestServer)

• Functional options pattern: withHandlerToken, withHandlerRegistry, withHandlerOrigins
• Creates minimal Server with safe defaults for all fields
• Enables httptest-based handler testing without full server setup
• Distinct from newTestServer (server_federation_test.go) which requires real kubeconfig

Tests included (9 test cases)

handleHealth (4 tests):

• GET returns 200 with status=ok and version
• CORS headers set for allowed origins
• OPTIONS preflight returns 204
• Disallowed origins get no ACAO header

handleStatus (5 tests):

• Missing token returns 401
• Valid Bearer token returns 200 with status payload
• OPTIONS preflight returns 204
• No token configured = endpoint accessible without auth

Impact

This test infrastructure enables future handler tests for the 31 currently untested server_*.go files identified in #17147.

Fixes #17147

---

Filed by quality agent (ACMM L3/L5 — hold-gated mode). Hold-gated: human review required.

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubestellarconsole canceled.

Name	Link
🔨 Latest commit	ce5212c
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a243a3ac537bb000857086f

[github-actions]

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

• Claude Code (Opus 4.5 / 4.6) — recommended
• GitHub Copilot
• Cursor
• Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

---

This is an automated message.

[Copilot]

Pull request overview

Adds a new unit-test helper for constructing a minimal *agent.Server and introduces focused httptest-based coverage for the /health and /status HTTP handlers, intended to unblock broader handler testing in pkg/agent.

Changes:

• Introduces newHandlerTestServer() with functional options to configure minimal Server instances for handler tests.
• Adds 9 unit tests covering handleHealth (CORS + preflight + payload) and handleStatus (auth + preflight + no-token mode).

[github-actions]

Status Check

This hold-gated quality PR has had no activity for ~5 hours and was missing the ai-needs-human label (now added).

Check state:

• ❌ post-directions — FAILING since 15:18 UTC — this is a systemic failure affecting multiple hold-gated AI-generated PRs; not specific to this PR's content and does not block review
• ✅ All other checks passing (builds linux/amd64 + arm64, go test ./..., Verify console starts, CodeQL, Copilot reviewer, ts-null-safety, pr-check)

Current state: PR carries the hold label (hold-gated mode — human review required). No new commits or activity since 15:21 UTC (~5 hours ago).

Recommended next steps for a human maintainer:

1. Review the 9 httptest-based unit tests covering handleHealth (CORS, preflight, payload) and handleStatus (auth, preflight, no-token mode)
2. If the test coverage and implementation are correct, remove the hold label to unblock merge
3. The post-directions failure is a known systemic issue on hold-gated AI PRs — it should not influence the review decision

Generated by Stuck Detection Workflow · sonnet46 2.8M · ◷

[github-actions]

Status Check (Follow-up — ~21h since last escalation)

PR: #17148 — [quality] Add handler test helper and health/status endpoint tests
Stuck since: opened 2026-06-06T15:18Z · no human action in ~26h

Current State

Check	Status
post-directions	❌ FAILING (systemic issue on hold-gated AI PRs — does not affect review)
All other checks (builds, go test ./..., CodeQL, Verify console starts, ts-null-safety, pr-check)	✅ PASSING
hold label	blocking merge
Human review	none

Summary

This PR introduces newHandlerTestServer() — a lightweight test constructor — and 9 httptest-based tests covering handleHealth (CORS, preflight, payload) and handleStatus (auth, preflight, no-token mode). No external dependencies or cluster access required.

Recommended Next Steps

1. Review the 9 unit tests and test helper implementation
2. The post-directions failure is a known systemic issue on hold-gated AI PRs and should not influence the review decision
3. If the implementation is correct, remove hold and provide /lgtm + /approve

Generated by Stuck Detection Workflow · sonnet46 4.2M · ◷