Skip to content

[kueue] Split e2e customconfigs jobs into baseline and extended#36839

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Mostafahassen1:split-kueue-customconfigs-jobs
Apr 22, 2026
Merged

[kueue] Split e2e customconfigs jobs into baseline and extended#36839
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
Mostafahassen1:split-kueue-customconfigs-jobs

Conversation

@Mostafahassen1
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Splits the long-running test-e2e-customconfigs Prow jobs for Kueue's main branch into two parallel jobs (baseline and extended).

This updates the CI to match the Makefile changes in the kueue repo, which will significantly speed up the E2E execution time.

Related PRs:

Depends on kubernetes-sigs/kueue kubernetes-sigs/kueue#10472

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Apr 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @Mostafahassen1!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/jobs needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @Mostafahassen1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Apr 18, 2026
@k8s-ci-robot k8s-ci-robot requested review from mimowo and tenzen-y April 18, 2026 12:27
@Mostafahassen1
Copy link
Copy Markdown
Contributor Author

/cc @mimowo

@k8s-triage-robot
Copy link
Copy Markdown

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2026
@tenzen-y
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 20, 2026
@kannon92
Copy link
Copy Markdown
Contributor

It'd be nice to see kubernetes-sigs/kueue#10595 close to merge before we approve this.

cc @mbobrovskyi

@kannon92
Copy link
Copy Markdown
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2026
@Mostafahassen1
Copy link
Copy Markdown
Contributor Author

Hi @kannon92, we have finished kubernetes-sigs/kueue#10595
. What is the next step?

This PR includes removing customconfigs, but it has not been removed in Kueue.

Does this mean we will merge this PR and, at the same time, open a new PR in Kueue to remove customconfigs?

I prefer not to merge this until we open a new PR in Kueue related to removing customconfigs.

What is your opinion?

@kannon92
Copy link
Copy Markdown
Contributor

It would probably be best to leave customconfigs alone and add new jobs.

And then once both are passing we can remove custom configs.

@Mostafahassen1
Copy link
Copy Markdown
Contributor Author

It would probably be best to leave customconfigs alone and add new jobs.
And then once both are passing we can remove custom configs.

@kannon92, this means I want to update this PR here because we do not need to remove customconfigs right now.

@kannon92
Copy link
Copy Markdown
Contributor

Yea that seems to be a good plan.

@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented Apr 21, 2026

@kannon92 @Mostafahassen1 iiuc we need to also Cherrypick kubernetes-sigs/kueue#10595 (comment) so that this PR can uniformly stop using customconfigs for all versions

@Mostafahassen1
Copy link
Copy Markdown
Contributor Author

ok @mimowo, first I will create a cherrypick for kubernetes-sigs/kueue#10595 (comment)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about kueue-periodics-release-0-16.yaml, kueue-periodics-release-0-17.yaml, kueue-presubmits-release-0-16.yaml and kueue-presubmits-release-0-17.yaml?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's adjust them too in the same PR as now all branches are aligned

Comment thread config/jobs/kubernetes-sigs/kueue/kueue-presubmits-main.yaml Outdated
@mimowo
Copy link
Copy Markdown
Contributor

mimowo commented Apr 22, 2026

Thank you!
/lgtm
/approve
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, Mostafahassen1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2026
@k8s-ci-robot k8s-ci-robot merged commit dae911b into kubernetes:master Apr 22, 2026
6 checks passed
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@Mostafahassen1: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kueue-periodics-main.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-periodics-main.yaml
  • key kueue-periodics-release-0-16.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-periodics-release-0-16.yaml
  • key kueue-periodics-release-0-17.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-periodics-release-0-17.yaml
  • key kueue-presubmits-main.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-main.yaml
  • key kueue-presubmits-release-0-16.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-release-0-16.yaml
  • key kueue-presubmits-release-0-17.yaml using file config/jobs/kubernetes-sigs/kueue/kueue-presubmits-release-0-17.yaml
Details

In response to this:

What this PR does / why we need it:

Splits the long-running test-e2e-customconfigs Prow jobs for Kueue's main branch into two parallel jobs (baseline and extended).

This updates the CI to match the Makefile changes in the kueue repo, which will significantly speed up the E2E execution time.

Related PRs:

Depends on kubernetes-sigs/kueue kubernetes-sigs/kueue#10472

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mostafahassen1
Copy link
Copy Markdown
Contributor Author

@mimowo, the next step is to work on Kueue to remove customconfigs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants