[kueue] Split e2e customconfigs jobs into baseline and extended#36839
Conversation
|
Welcome @Mostafahassen1! |
|
Hi @Mostafahassen1. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @mimowo |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
/ok-to-test |
|
It'd be nice to see kubernetes-sigs/kueue#10595 close to merge before we approve this. cc @mbobrovskyi |
|
/hold |
|
Hi @kannon92, we have finished kubernetes-sigs/kueue#10595 This PR includes removing customconfigs, but it has not been removed in Kueue. Does this mean we will merge this PR and, at the same time, open a new PR in Kueue to remove customconfigs? I prefer not to merge this until we open a new PR in Kueue related to removing customconfigs. What is your opinion? |
|
It would probably be best to leave customconfigs alone and add new jobs. And then once both are passing we can remove custom configs. |
@kannon92, this means I want to update this PR here because we do not need to remove customconfigs right now. |
|
Yea that seems to be a good plan. |
|
@kannon92 @Mostafahassen1 iiuc we need to also Cherrypick kubernetes-sigs/kueue#10595 (comment) so that this PR can uniformly stop using customconfigs for all versions |
|
ok @mimowo, first I will create a cherrypick for kubernetes-sigs/kueue#10595 (comment) |
There was a problem hiding this comment.
What about kueue-periodics-release-0-16.yaml, kueue-periodics-release-0-17.yaml, kueue-presubmits-release-0-16.yaml and kueue-presubmits-release-0-17.yaml?
There was a problem hiding this comment.
+1, let's adjust them too in the same PR as now all branches are aligned
|
Thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, Mostafahassen1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Mostafahassen1: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mimowo, the next step is to work on Kueue to remove |
What this PR does / why we need it:
Splits the long-running
test-e2e-customconfigsProw jobs for Kueue'smainbranch into two parallel jobs (baselineandextended).This updates the CI to match the Makefile changes in the
kueuerepo, which will significantly speed up the E2E execution time.Related PRs:
Depends on kubernetes-sigs/kueue kubernetes-sigs/kueue#10472