Add presubmit jobs tests and linting for sig-security tool srctl #36801
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| --- | ||
| presubmits: | ||
| kubernetes/sig-security: | ||
| - name: pull-sig-security-srctl-tests | ||
| cluster: eks-prow-build-cluster | ||
| annotations: | ||
| testgrid-dashboards: sig-security-srctl | ||
| testgrid-create-test-group: "true" | ||
| description: Run unit tests for srctl | ||
| run_if_changed: "^sig-security-tooling/srctl/" | ||
| branches: | ||
| - main | ||
| decorate: true | ||
| spec: | ||
| containers: | ||
| - image: public.ecr.aws/docker/library/golang:1.25@sha256:ed520ab5bed37ce887012c050ced60f7d52dfcd212e3dc6fdd8951e9c4e25c1a | ||
| command: ['go'] | ||
| workingDir: sig-security-tooling/srctl | ||
| args: ['test', '-v', '-cover', './...'] | ||
| resources: | ||
| limits: | ||
| cpu: 1 | ||
| memory: "256Mi" | ||
| requests: | ||
| cpu: 1 | ||
| memory: "256Mi" | ||
|
|
||
| - name: pull-sig-security-srctl-lint | ||
| cluster: eks-prow-build-cluster | ||
| annotations: | ||
| testgrid-dashboards: sig-security-srctl | ||
| testgrid-create-test-group: "true" | ||
| description: Run linters for srctl | ||
| run_if_changed: "^sig-security-tooling/srctl/" | ||
| branches: | ||
| - main | ||
| decorate: true | ||
| spec: | ||
| containers: | ||
| - image: public.ecr.aws/docker/library/golang:1.25@sha256:ed520ab5bed37ce887012c050ced60f7d52dfcd212e3dc6fdd8951e9c4e25c1a | ||
| command: | ||
| - /bin/bash | ||
| - -c | ||
| - | | ||
| set -euo pipefail | ||
| cd sig-security-tooling/srctl | ||
| go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.4 | ||
|
Comment on lines
+44
to
+47
Member
There was a problem hiding this comment. maybe would be cool to have an image that already includes
Author
There was a problem hiding this comment. I could try figuring out where Kubernetes keeps their images and try that, it would fit well. I'll ask what the test-infra slack thinks.
Member
There was a problem hiding this comment. I would strongly encourage moving this into the sig security repo and generally putting test target definitions and verisons there, as breifly discussed in the slack thread This makes it easier for contributors to reproduce, and makes it safe to iterate on the options and versions (because the PR that changes them will run the tests before merge) |
||
| export PATH=$PATH:$(go env GOPATH)/bin | ||
| golangci-lint run ./... | ||
| resources: | ||
| limits: | ||
| cpu: 1 | ||
| memory: "512Mi" | ||
| requests: | ||
| cpu: 1 | ||
| memory: "512Mi" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen your comment
Tbh I'll use whatever is maintained by sig test-infra and they think is a good image. Maybe it would be interesting to ask them what they think is a good image for our use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They told me the image I chose was fine.
https://kubernetes.slack.com/archives/C09QZ4DQB/p1776265122708969
On the flip side I do need to do some work on the golangci-lint side because the version for that that gets used should be decided in the source directory of srctl, not here in test-infra so I need to update that which means a PR over there combined with this PR being updated to take advantage of that.