Skip to content

Improve s390x conformance test cleanup and error handling#36659

Open
sudharshanibm wants to merge 1 commit intokubernetes:masterfrom
sudharshanibm:fix-s390x-conformance-cleanup
Open

Improve s390x conformance test cleanup and error handling#36659
sudharshanibm wants to merge 1 commit intokubernetes:masterfrom
sudharshanibm:fix-s390x-conformance-cleanup

Conversation

@sudharshanibm
Copy link
Copy Markdown
Member

@sudharshanibm sudharshanibm commented Mar 15, 2026 •
edited
Loading

  • Add comprehensive cleanup function with trap on EXIT
  • Ensure Boskos resource release even on test failures
  • Properly handle heartbeat process termination
  • Continue to serial tests even if parallel tests fail
  • Fix SSH key name to use k8s-s390x-ssh-key
  • Remove --break-kubetest-on-upfail to allow cleanup on failures

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sudharshanibm
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 15, 2026

Hi @sudharshanibm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/jobs sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 15, 2026
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2026
@sudharshanibm sudharshanibm force-pushed the fix-s390x-conformance-cleanup branch 6 times, most recently from 03b1922 to 148544c Compare March 16, 2026 08:37
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2026
@sudharshanibm sudharshanibm force-pushed the fix-s390x-conformance-cleanup branch from 1ec51ca to 1d7e7a3 Compare March 16, 2026 08:50
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2026
@sudharshanibm sudharshanibm force-pushed the fix-s390x-conformance-cleanup branch 4 times, most recently from 603001d to d973fe3 Compare March 16, 2026 14:59
@sudharshanibm sudharshanibm force-pushed the fix-s390x-conformance-cleanup branch from d973fe3 to 82488eb Compare March 27, 2026 16:19
@sudharshanibm sudharshanibm force-pushed the fix-s390x-conformance-cleanup branch from 82488eb to 1db7cfe Compare April 6, 2026 05:29
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2026
@sudharshanibm sudharshanibm force-pushed the fix-s390x-conformance-cleanup branch from 1db7cfe to 3bc0739 Compare April 6, 2026 05:31
@sudharshanibm sudharshanibm changed the title Refactor Boskos, add VPC env vars & cleanup Improve s390x conformance test cleanup and error handling Apr 6, 2026
@sudharshanibm
Improve s390x conformance test cleanup and error handling
4a0a9eb 
- Add comprehensive cleanup function with trap on EXIT
- Ensure Boskos resource release even on test failures
- Properly handle heartbeat process termination
- Continue to serial tests even if parallel tests fail
- Fix SSH key name to use k8s-s390x-ssh-key
- Improve error handling and logging throughout
- Remove --break-kubetest-on-upfail to allow cleanup on failures

This change ensures proper resource cleanup and Boskos resource
management for s390x conformance tests, preventing resource leaks
and improving test reliability.

Signed-off-by: Sudharshan Muralidharan <sudharshan.muralidharan1@ibm.com>
@sudharshanibm sudharshanibm force-pushed the fix-s390x-conformance-cleanup branch from 9dd4907 to 4a0a9eb Compare April 6, 2026 08:17
This was referenced Apr 6, 2026
Open
Open
@sudharshanibm sudharshanibm mentioned this pull request Apr 17, 2026
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkumatag mkumatag Awaiting requested review from mkumatag

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

No one assigned

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sudharshanibm @k8s-ci-robot