Fix warning related to Printf like formatting that became build error…#3090
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Apr 22, 2026
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
08volt
reviewed
Apr 20, 2026
| } else if exists { | ||
| svcAttachment := obj.(*sav1.ServiceAttachment) | ||
| c.recorder(svcAttachment.Namespace).Eventf(svcAttachment, v1.EventTypeWarning, "ProcessServiceAttachmentFailed", eventMsg) | ||
| c.recorder(svcAttachment.Namespace).Eventf(svcAttachment, v1.EventTypeWarning, "ProcessServiceAttachmentFailed", "error processing service attachment %q: %q", key, err) |
Member
There was a problem hiding this comment.
Nit: we could keep using "eventMsg" and just use "Event" instead of Eventf:
c.recorder(svcAttachment.Namespace).Event(svcAttachment, v1.EventTypeWarning, "ProcessServiceAttachmentFailed", eventMsg)
Contributor
Author
There was a problem hiding this comment.
changed it to use Event
k8s-ci-robot
added
the
lgtm
…s in go1.26 (code won't build without fixing this)
mmamczur
force-pushed
the
printf-like_errors
branch
from
26d2a45 to
d4ff640
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
Author
|
/assign @kl52752 |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 08volt, kl52752, mmamczur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s in go1.26 (code won't build without fixing this on go 1.26)
This is done in preparation for k8s 1.36 that requires go 1.26.