Clarify the VPA's ability to traverse ownership chains#9480
Open
adrianmoisey wants to merge 1 commit intokubernetes:masterfrom
Open
Clarify the VPA's ability to traverse ownership chains#9480adrianmoisey wants to merge 1 commit intokubernetes:masterfrom
adrianmoisey wants to merge 1 commit intokubernetes:masterfrom
Conversation
Also change names in tests a little to be clearer
k8s-ci-robot
added
release-note-none
Member
Author
|
/retest |
omerap12
approved these changes
Apr 13, 2026
| were specified manually. | ||
|
|
||
| > [!WARNING] | ||
| > VPA can only manage Pods that are directly owned by the targeted Custom Resource. It does not support indirect ownership (e.g., targeting a resource that owns another controller, which in turn owns the Pods). |
Member
There was a problem hiding this comment.
Can we also mentioned that we are currently working to find a solution?
Member
Author
There was a problem hiding this comment.
I don't really want to make promises about the future, I'd rather just say how it is.
If anyone is interested, they can go looking at issues
Comment on lines
+62
to
+65
| "Foo": { | ||
| {Kind: "NotScalingResource", Name: "iCanNotScale", Group: "foo"}, | ||
| {Kind: "ScalingResource", Name: "iCanScale", Group: "foo"}, | ||
| }, |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
What this PR does / why we need it:
Clarify the VPA's ability to traverse ownership chains
Also change names in tests a little to be clearer
My plan was to make a test that proved the current behaviour, but with our current testing framework that was a bit difficult.
Which issue(s) this PR fixes:
Relates to #9072
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc iamzili