Skip to content

cluster-autoscaler: honor stderrthreshold when logtostderr is enabled#9408

Open
pierluigilenoci wants to merge 2 commits intokubernetes:masterfrom
pierluigilenoci:fix/honor-stderrthreshold
Open

cluster-autoscaler: honor stderrthreshold when logtostderr is enabled#9408
pierluigilenoci wants to merge 2 commits intokubernetes:masterfrom
pierluigilenoci:fix/honor-stderrthreshold

Conversation

@pierluigilenoci
Copy link
Copy Markdown
Contributor

@pierluigilenoci pierluigilenoci commented Mar 24, 2026 •
edited
Loading

Summary

  • Update k8s.io/klog/v2 to v2.140.0 which includes the fix for kubernetes/klog#212
  • Opt into the new klog behavior by setting -legacy_stderr_threshold_behavior=false
  • Set -stderrthreshold=INFO to preserve backward-compatible behavior
  • Users can now override -stderrthreshold to WARNING or ERROR to reduce stderr noise

This addresses complaints about log aggregation systems (DataDog, CloudWatch) misclassifying INFO messages as errors because all logs go to stderr.

Related: #3033, #2333, #8302

Ref: kubernetes/klog#212, kubernetes/klog#432

Signed-off-by: Pierluigi Lenoci pierluigi.lenoci@gmail.com

cluster-autoscaler: Honor -stderrthreshold flag when -logtostderr=true by opting into klog v2.140.0 fix

@pierluigilenoci
cluster-autoscaler: honor stderrthreshold when logtostderr is enabled
ab3caa1 
Update k8s.io/klog/v2 to v2.140.0 and opt into the new behavior where
-stderrthreshold is respected even when -logtostderr=true. This allows
users to set -stderrthreshold=WARNING or -stderrthreshold=ERROR to
reduce stderr noise, which helps log aggregation systems (DataDog,
CloudWatch) avoid misclassifying INFO messages as errors.

Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/cluster-autoscaler do-not-merge/needs-area labels Mar 24, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pierluigilenoci
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-area do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 24, 2026
@pierluigilenoci pierluigilenoci mentioned this pull request Mar 24, 2026
Merged
@pierluigilenoci
Copy link
Copy Markdown
Contributor Author

pierluigilenoci commented Mar 24, 2026

cc @towca @x13n — would you be able to review this when you get a chance? All CI checks are green. This opts into the klog fix for kubernetes/klog#212 so that -stderrthreshold is honored even when -logtostderr=true in cluster-autoscaler.

@pierluigilenoci
Copy link
Copy Markdown
Contributor Author

pierluigilenoci commented Mar 27, 2026

Gentle ping — could you take a look when you get a chance? Happy to address any feedback. Thank you!

@pierluigilenoci
Copy link
Copy Markdown
Contributor Author

pierluigilenoci commented Apr 10, 2026

Friendly follow-up — this PR has been open for about two and a half weeks with all CI checks green (tests, verify, E2E build all passing). @towca @x13n @BigDarkClown would any of you have a few minutes to review this cluster-autoscaler klog stderrthreshold fix? Happy to address any feedback. Thank you!

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 13, 2026

@pierluigilenoci: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-autoscaling-e2e-gci-gce-ca-test 22d691a link false /test pull-autoscaling-e2e-gci-gce-ca-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@vadasambar vadasambar Awaiting requested review from vadasambar

Assignees

No one assigned

Labels

area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pierluigilenoci @k8s-ci-robot