Skip to content

Makes GCE manager handle createInstances call of more than 1k instances#9315

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pmendelski:mendel-2k-scale-up
Apr 14, 2026
Merged

Makes GCE manager handle createInstances call of more than 1k instances#9315
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pmendelski:mendel-2k-scale-up

Conversation

@pmendelski
Copy link
Copy Markdown
Contributor

@pmendelski pmendelski commented Mar 4, 2026 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Makes GCE manager handle createInstances call of more than 1k instances.

Single createInstances GCE call is limited to 1000 instances. It's enforced in GCE validation.
GCE manager sends a sequence of request to overcome this limitation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

GCE Provider: Support scale-up events larger than 1,000 nodes. The GCE provider now handles API validation limits internally, allowing `--max-nodes-per-scaleup` to be configured above 1,000.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-area labels Mar 4, 2026
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 4, 2026

Hi @pmendelski. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/provider/gce size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-area do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 4, 2026
@pmendelski
Copy link
Copy Markdown
Contributor Author

pmendelski commented Mar 4, 2026

cc @x13n

@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Mar 5, 2026

/ok-to-test
/assign @jbtk

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2026
damikag
damikag reviewed Mar 10, 2026
View reviewed changes
damikag
damikag reviewed Mar 10, 2026
View reviewed changes
@damikag
Copy link
Copy Markdown
Member

damikag commented Mar 10, 2026

/assign damikag
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2026
jbtk
jbtk reviewed Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jbtk jbtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any further plan to use it? Can you provide more context?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2026
@damikag
Copy link
Copy Markdown
Member

damikag commented Mar 11, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2026
@pmendelski pmendelski mentioned this pull request Mar 11, 2026
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2026
x13n
x13n reviewed Mar 11, 2026
View reviewed changes
@jbtk jbtk mentioned this pull request Mar 12, 2026
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2026
@pmendelski pmendelski changed the title Return generated instance names from autoscaling GCE client Return generated instance ids from autoscaling GCE client Apr 10, 2026
@x13n
Copy link
Copy Markdown
Member

x13n commented Apr 10, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmendelski, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2026
@pmendelski
Copy link
Copy Markdown
Contributor Author

pmendelski commented Apr 10, 2026

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2026
@pmendelski pmendelski changed the title Return generated instance ids from autoscaling GCE client Create more than 1k instances in on GCE manager call Apr 12, 2026
@pmendelski pmendelski changed the title Create more than 1k instances in on GCE manager call Makes GCE manager handle createInstances call of more than 1k instances Apr 12, 2026
@pmendelski
Copy link
Copy Markdown
Contributor Author

pmendelski commented Apr 13, 2026

Awaits e2e test fix #9470

@x13n
Copy link
Copy Markdown
Member

x13n commented Apr 14, 2026

e2e test fix was merged, can you rebase?

@pmendelski
Return generated instance names from autoscaling GCE client
d544b6c 
When there are multiple `createInstances` requests sent in a sequence,
the next request must be aware of the instance names used by the
previous request. Without this change sending a sequence of create
instances requests would result in the instance name duplication error.
@pmendelski
Copy link
Copy Markdown
Contributor Author

pmendelski commented Apr 14, 2026

e2e test pull-autoscaling-e2e-gci-gce-ca-test failed again. This time failed on the cluster creation. Sample errors:

ERROR: (gcloud.compute.instances.create) Could not fetch resource:
 - Invalid value for field 'resource.disks[0].initializeParams.sourceImage': '...'
Failed to create firewall rule.
ERROR: (gcloud.compute.ssh) Could not fetch resource:
 - The resource 'projects/k8s-infra-e2e-boskos-098/zones/us-central1-b/instances/bootstrap-e2e-master' was not found

/retest

@x13n
Copy link
Copy Markdown
Member

x13n commented Apr 14, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 14, 2026
@pmendelski
Copy link
Copy Markdown
Contributor Author

pmendelski commented Apr 14, 2026

Test passed, PR type changed to feature and added release note
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2026
@k8s-ci-robot k8s-ci-robot merged commit 41d87a6 into kubernetes:master Apr 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@x13n x13n x13n left review comments

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

+2 more reviewers

@jbtk jbtk jbtk left review comments

@damikag damikag damikag left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@x13n x13n

@jbtk jbtk

@damikag damikag

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pmendelski @k8s-ci-robot @jackfrancis @damikag @jbtk @x13n @aleksandra-malinowska @mbrow137