Skip to content

chore: update make test target to only run where _test files exist#48

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
jaideepr97:fix-make-test-target
Mar 19, 2026
Merged

chore: update make test target to only run where _test files exist#48
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
jaideepr97:fix-make-test-target

Conversation

@jaideepr97
Copy link
Copy Markdown
Contributor

@jaideepr97 jaideepr97 commented Mar 19, 2026

currently there is a go version mismatch between what is in the go.mod file (1.25.8) and what the CI job uses (1.24) which might be causing a dynamic download of 1.25.8 in the CI, which doesn't include the covdata tool
Hence we are currently seeing an error in CI when make test runs against folders that don't contain any _test files

Setting up envtest binaries for Kubernetes version 1.35...
/home/prow/go/src/github.com/kubernetes-sigs/mcp-lifecycle-operator/bin/k8s/1.35.0-linux-amd64KUBEBUILDER_ASSETS="/home/prow/go/src/github.com/kubernetes-sigs/mcp-lifecycle-operator/bin/k8s/1.35.0-linux-amd64" go test $(go list ./... | grep -v /e2e) -coverprofile cover.out
ok  	github.com/kubernetes-sigs/mcp-lifecycle-operator/api/v1alpha1	13.481s	coverage: 0.7% of statements
# github.com/kubernetes-sigs/mcp-lifecycle-operator/cmd
go: no such tool "covdata"
# github.com/kubernetes-sigs/mcp-lifecycle-operator/test/utils
go: no such tool "covdata"
ok  	github.com/kubernetes-sigs/mcp-lifecycle-operator/internal/controller	10.688s	coverage: 78.7% of statements
make: *** [Makefile:65: test] Error 1

as we can see, the actual tests run fine, it only fails on folders that don't contain any test files
This PR updates the make target so that it skips those folders

A separate PR has been raised to update the CI image to 1.25 - kubernetes/test-infra#36688

Signed-off-by: Jaideep Rao <jrao@redhat.com>
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 19, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @jaideepr97. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2026
@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 19, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2026
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for looking into this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaideepr97, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2026
@k8s-ci-robot k8s-ci-robot merged commit 2f62fde into kubernetes-sigs:main Mar 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants