chore: update make test target to only run where _test files exist#48
Conversation
Signed-off-by: Jaideep Rao <jrao@redhat.com>
|
Hi @jaideepr97. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
matzew
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks for looking into this!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaideepr97, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
currently there is a go version mismatch between what is in the
go.modfile (1.25.8) and what the CI job uses (1.24) which might be causing a dynamic download of 1.25.8 in the CI, which doesn't include thecovdatatoolHence we are currently seeing an error in CI when
make testruns against folders that don't contain any _test filesas we can see, the actual tests run fine, it only fails on folders that don't contain any test files
This PR updates the make target so that it skips those folders
A separate PR has been raised to update the CI image to 1.25 - kubernetes/test-infra#36688