feat(ui): make federated dev server ports configurable#2563
Open
mturley wants to merge 1 commit intokubeflow:mainfrom
Open
feat(ui): make federated dev server ports configurable#2563mturley wants to merge 1 commit intokubeflow:mainfrom
mturley wants to merge 1 commit intokubeflow:mainfrom
Conversation
Add FEDERATED_FRONTEND_PORT and FEDERATED_BFF_PORT Make variables with conditional assignment (?=) so they can be overridden via environment variables. This allows running multiple federated dev environments simultaneously on different ports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/retest |
Contributor
|
/lgtm |
Contributor
|
@Philip-Carneiro: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEDERATED_FRONTEND_PORTandFEDERATED_BFF_PORTMake variables with conditional assignment (?=) toclients/ui/MakefileMotivation
When working with multiple git worktrees (e.g. working with agents on multiple branches or reviewing/testing multiple PRs), each worktree needs its own set of dev servers. Currently the federated dev targets hardcode
PORT=9100andPORT=4000, so only one instance can run at a time. This change makes the ports configurable while preserving the existing defaults.Test plan
make dev-start-federatedwith no env vars — should behave identically to before (ports 9100 and 4000)FEDERATED_FRONTEND_PORT=9200 FEDERATED_BFF_PORT=4100 make dev-start-federated— should start on the overridden ports🤖 Generated with Claude Code