Skip to content

Add Hugging Face organization slug helper under Allowed organization #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-oss-prow merged 3 commits into from
Apr 21, 2026
Merged

Add Hugging Face organization slug helper under Allowed organization #2600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e0abb0
add helper text for hf
Taj010 Apr 15, 2026
be4fd3d
adjust the message
Taj010 Apr 16, 2026
6629d8e
rebase and adjust
Taj010 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions clients/ui/frontend/src/app/pages/modelCatalogSettings/components/CredentialsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,22 @@ const CredentialsSection: React.FC<CredentialsSectionProps> = ({
) : undefined;

const organizationFormGroup = (
<ThemeAwareFormGroupWrapper
label={FORM_LABELS.ORGANIZATION}
fieldId="organization"
isRequired
descriptionTextNode={organizationDescriptionTxtNode}
helperTextNode={organizationHelperTxtNode}
>
{organizationInput}
</ThemeAwareFormGroupWrapper>
<>
<ThemeAwareFormGroupWrapper
label={FORM_LABELS.ORGANIZATION}
fieldId="organization"
isRequired
descriptionTextNode={organizationDescriptionTxtNode}
helperTextNode={organizationHelperTxtNode}
>
{organizationInput}
</ThemeAwareFormGroupWrapper>
<FormHelperText>
<HelperText>
<HelperTextItem>{HELPER_TEXT.ORGANIZATION_SLUG}</HelperTextItem>
</HelperText>
</FormHelperText>
</>
Comment on lines +92 to +106
Copy link
Copy Markdown
Contributor

@Philip-Carneiro Philip-Carneiro Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will conflict with #2526 and will break the logic added there

);

const accessTokenInput = (
Expand Down
2 changes: 2 additions & 0 deletions clients/ui/frontend/src/app/pages/modelCatalogSettings/constants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ export const DESCRIPTION_TEXT = {
export const HELPER_TEXT = {
ACCESS_TOKEN: 'Enter your Hugging Face access token.',
YAML: 'Upload or paste a YAML string.',
ORGANIZATION_SLUG:
'Hugging Face organization’s name is case-sensitive and should match the organization’s URL, which may differ from the displayed name. Use the organization’s URL slug found in the URL (e.g., Input: meta-llama from huggingface.co/meta-llama).',
Comment on lines +50 to +51
Copy link
Copy Markdown
Contributor

@Philip-Carneiro Philip-Carneiro Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have the same problem from the previous comment, it should wait for the merge of #2526 and add following the const and logic there

} as const;

export const PLACEHOLDERS = {
Expand Down
Loading