-
Notifications
You must be signed in to change notification settings - Fork 99
feat(pipelines): integrate GitHub issues ingestion into RAG pipeline #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -420,6 +420,24 @@ def github_rag_pipeline( | |||||
| github_token=github_token | ||||||
| ) | ||||||
|
|
||||||
| issues_task = download_github_issues( | ||||||
| repos=f"{repo_owner}/{repo_name}", | ||||||
| labels="", | ||||||
| state="open", | ||||||
| max_issues_per_repo=50, | ||||||
| github_token=github_token | ||||||
| ) | ||||||
|
|
||||||
| issues_chunk_task = chunk_and_embed( | ||||||
| github_data=issues_task.outputs["issues_data"], | ||||||
| repo_name="kubeflow-issues", | ||||||
| base_url="https://github.com", | ||||||
|
||||||
| base_url="https://github.com", | |
| base_url="", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
You're right that using html_url from the GitHub API would produce more accurate citations for issues.
To keep this PR focused on integrating issues ingestion without modifying existing chunk_and_embed behavior, I’ve kept the current approach unchanged.
I’m happy to open a follow-up PR to update chunk_and_embed to prefer html_url when available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repos list for
download_github_issuesis hard-coded tokubeflow/kubeflow,kubeflow/pipelines, which makesgithub_rag_pipelineless reusable and inconsistent with the existingrepo_owner/repo_nameparameters. Consider adding a pipeline parameter (e.g.,issues_repos) with this as the default, or deriving it from existing inputs.