Repository navigation
build(deps): update Kruize image versions - #165
kruize-version-sync[bot] wants to merge 1 commit into
Conversation
Signed-off-by: kruize-version-sync <2884050+kruize-version-sync[bot]@users.noreply.github.com>
Reviewer's GuideConfigurationUpdate the sample Kruize configuration and the default Autotune image tag to version 0.11.2.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="internal/constants/kruize_images.go" line_range="36" />
<code_context>
const (
// defaultAutotuneImageTag is the default tag for Kruize Autotune image
- defaultAutotuneImageTag = "0.11.1"
+ defaultAutotuneImageTag = "0.11.2"
// defaultUIImageTag is the default tag for Kruize UI image
</code_context>
<issue_to_address>
**Existing deployments keep old image**
When the operator is upgraded while an existing Kruize CR has an empty `autotune_image`, the generator resolves the new default, but `reconcileNamespacedResource` returns without updating the existing Deployment, so installations continue running the old image.
Update the reconciliation path to apply the newly resolved image to existing Deployments.
</issue_to_address>
### Comment 2
<location path="config/samples/v1alpha1_kruize.yaml" line_range="11" />
<code_context>
# Supported values: "openshift", "minikube", "kind"
cluster_type: "openshift"
- autotune_image: "quay.io/kruize/autotune_operator:0.11.1"
+ autotune_image: "quay.io/kruize/autotune_operator:0.11.2"
autotune_ui_image: "quay.io/kruize/kruize-ui:0.1.0"
optimizer_image: "quay.io/kruize/kruize-optimizer:0.0.1"
</code_context>
<issue_to_address>
**OLM examples deploy old image**
When an OLM user creates a Kruize resource from the bundle's `alm-examples`, the CSV's `alm-examples` supplies `quay.io/kruize/autotune_operator:0.11` explicitly, so `deployKruizeComponents` passes that value to the generator instead of using the new default, and the resource deploys the old image instead of 0.11.2.
Update the CSV's embedded `alm-examples` image to `quay.io/kruize/autotune_operator:0.11.2`.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: internal/constants/kruize_images.go:36, config/samples/v1alpha1_kruize.yaml:11
| const ( | ||
| // defaultAutotuneImageTag is the default tag for Kruize Autotune image | ||
| defaultAutotuneImageTag = "0.11.1" | ||
| defaultAutotuneImageTag = "0.11.2" |
There was a problem hiding this comment.
🟡 Medium · Existing deployments keep old image
When the operator is upgraded while an existing Kruize CR has an empty autotune_image, the generator resolves the new default, but reconcileNamespacedResource returns without updating the existing Deployment, so installations continue running the old image.
Update the reconciliation path to apply the newly resolved image to existing Deployments.
Prompt for AI agents
In `internal/constants/kruize_images.go` at line 36:
**Existing deployments keep old image**
When the operator is upgraded while an existing Kruize CR has an empty `autotune_image`, the generator resolves the new default, but `reconcileNamespacedResource` returns without updating the existing Deployment, so installations continue running the old image.
Update the reconciliation path to apply the newly resolved image to existing Deployments.| # Supported values: "openshift", "minikube", "kind" | ||
| cluster_type: "openshift" | ||
| autotune_image: "quay.io/kruize/autotune_operator:0.11.1" | ||
| autotune_image: "quay.io/kruize/autotune_operator:0.11.2" |
There was a problem hiding this comment.
🟡 Medium · OLM examples deploy old image
When an OLM user creates a Kruize resource from the bundle's alm-examples, the CSV's alm-examples supplies quay.io/kruize/autotune_operator:0.11 explicitly, so deployKruizeComponents passes that value to the generator instead of using the new default, and the resource deploys the old image instead of 0.11.2.
Update the CSV's embedded alm-examples image to quay.io/kruize/autotune_operator:0.11.2.
Prompt for AI agents
In `config/samples/v1alpha1_kruize.yaml` at line 11:
**OLM examples deploy old image**
When an OLM user creates a Kruize resource from the bundle's `alm-examples`, the CSV's `alm-examples` supplies `quay.io/kruize/autotune_operator:0.11` explicitly, so `deployKruizeComponents` passes that value to the generator instead of using the new default, and the resource deploys the old image instead of 0.11.2.
Update the CSV's embedded `alm-examples` image to `quay.io/kruize/autotune_operator:0.11.2`.
Automated Version Update
Updates Kruize image versions from upstream repositories.
Autotune: 0.11 → 0.11.2
UI: 0.1.0 → 0.1.0
Summary by Sourcery
Enhancements: