Repository navigation
build(deps): update Kruize image versions - #164
kruize-version-sync[bot] wants to merge 1 commit into
Conversation
Signed-off-by: kruize-version-sync <2884050+kruize-version-sync[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Kruize Autotune image references from 0.11.1 to 0.11.2 in both the sample configuration and the operator default, while leaving the UI and optimizer image versions unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="config/samples/v1alpha1_kruize.yaml" line_range="11" />
<code_context>
# Supported values: "openshift", "minikube", "kind"
cluster_type: "openshift"
- autotune_image: "quay.io/kruize/autotune_operator:0.11.1"
+ autotune_image: "quay.io/kruize/autotune_operator:0.11.2"
autotune_ui_image: "quay.io/kruize/kruize-ui:0.1.0"
optimizer_image: "quay.io/kruize/kruize-optimizer:0.0.1"
</code_context>
<issue_to_address>
**OLM examples deploy old image**
When an OLM user creates a Kruize resource from the CSV's embedded example, the CSV's `alm-examples` still sets `autotune_image` to `quay.io/kruize/autotune_operator:0.11`; `deployKruizeComponents` passes that explicit value instead of applying the new default, so the resource deploys the older Autotune image.
Update the CSV's embedded `alm-examples` to use `quay.io/kruize/autotune_operator:0.11.2`.
</issue_to_address>
### Comment 2
<location path="internal/constants/kruize_images.go" line_range="36" />
<code_context>
const (
// defaultAutotuneImageTag is the default tag for Kruize Autotune image
- defaultAutotuneImageTag = "0.11.1"
+ defaultAutotuneImageTag = "0.11.2"
// defaultUIImageTag is the default tag for Kruize UI image
</code_context>
<issue_to_address>
**Existing installs keep old Autotune**
When an existing installation upgrades the operator and its Kruize CR leaves `autotune_image` empty, `NewKruizeResourceGenerator` builds the Deployment with the new default image, but `reconcileNamespacedResource` returns without updating an existing Deployment. Upgraded installations therefore keep running the old Autotune image despite the new default.
Update existing generated resources when their desired spec changes, or otherwise trigger their replacement during the image-version upgrade.
</issue_to_address>Sourcery assessment
Approval pending. 2 findings to address first.
Blocking findings: config/samples/v1alpha1_kruize.yaml:11, internal/constants/kruize_images.go:36
| # Supported values: "openshift", "minikube", "kind" | ||
| cluster_type: "openshift" | ||
| autotune_image: "quay.io/kruize/autotune_operator:0.11.1" | ||
| autotune_image: "quay.io/kruize/autotune_operator:0.11.2" |
There was a problem hiding this comment.
🟡 Medium · OLM examples deploy old image
When an OLM user creates a Kruize resource from the CSV's embedded example, the CSV's alm-examples still sets autotune_image to quay.io/kruize/autotune_operator:0.11; deployKruizeComponents passes that explicit value instead of applying the new default, so the resource deploys the older Autotune image.
Update the CSV's embedded alm-examples to use quay.io/kruize/autotune_operator:0.11.2.
Prompt for AI agents
In `config/samples/v1alpha1_kruize.yaml` at line 11:
**OLM examples deploy old image**
When an OLM user creates a Kruize resource from the CSV's embedded example, the CSV's `alm-examples` still sets `autotune_image` to `quay.io/kruize/autotune_operator:0.11`; `deployKruizeComponents` passes that explicit value instead of applying the new default, so the resource deploys the older Autotune image.
Update the CSV's embedded `alm-examples` to use `quay.io/kruize/autotune_operator:0.11.2`.| const ( | ||
| // defaultAutotuneImageTag is the default tag for Kruize Autotune image | ||
| defaultAutotuneImageTag = "0.11.1" | ||
| defaultAutotuneImageTag = "0.11.2" |
There was a problem hiding this comment.
🟡 Medium · Existing installs keep old Autotune
When an existing installation upgrades the operator and its Kruize CR leaves autotune_image empty, NewKruizeResourceGenerator builds the Deployment with the new default image, but reconcileNamespacedResource returns without updating an existing Deployment. Upgraded installations therefore keep running the old Autotune image despite the new default.
Update existing generated resources when their desired spec changes, or otherwise trigger their replacement during the image-version upgrade.
Prompt for AI agents
In `internal/constants/kruize_images.go` at line 36:
**Existing installs keep old Autotune**
When an existing installation upgrades the operator and its Kruize CR leaves `autotune_image` empty, `NewKruizeResourceGenerator` builds the Deployment with the new default image, but `reconcileNamespacedResource` returns without updating an existing Deployment. Upgraded installations therefore keep running the old Autotune image despite the new default.
Update existing generated resources when their desired spec changes, or otherwise trigger their replacement during the image-version upgrade.
Automated Version Update
Updates Kruize image versions from upstream repositories.
Autotune: 0.11 → 0.11.2
UI: 0.1.0 → 0.1.0
Summary by Sourcery
Enhancements: