Fix make run-in-kind by upgrading KRM function versions in Dockerfile - #1166
Fix make run-in-kind by upgrading KRM function versions in Dockerfile#1166liamfallon wants to merge 3 commits into
make run-in-kind by upgrading KRM function versions in Dockerfile#1166Conversation
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates the function-runner build image set to use a newer ensure-name-substring KRM function image so make run-in-kind can successfully build and deploy Porch in a kind cluster.
Changes:
- Bump
ensure-name-substringfunction image fromv0.2.1tov0.3.0infunc/Dockerfile.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The implemented version bumps expand beyond what the PR description/title claims, increasing scope/risk without documented rationale.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
liamfallon
changed the title
make run-in-kind by upgrading ensure-name-substringmake run-in-kind by upgrading KRM function versions in Dockerfile
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
ea547d1 to
ef5794b
Compare
|
Fix make run-in-kind by upgrading KRM function versions in Dockerfile
Description
make run-in-kindtarget was failingRelated Issue(s)
Type of Change
Checklist
AI Disclosure