Proofreading chapter 2 - #4487
Open
mpgreaves wants to merge 12 commits into
Open
Conversation
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
mpgreaves
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
April 16, 2026 09:00
dosubot
Bot
added
the
size:L
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR proofreads and rephrases Chapter 2 (“Concepts”) of the kpt book, aiming to improve clarity and readability of the documentation content.
Changes:
- Reworded multiple sections for improved grammar and readability.
- Restructured several paragraphs into bullet/numbered lists and expanded some explanations.
- Updated wording and formatting across the “Packages”, “Workflows”, and “Functions” sections.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Assisted-by: Copilot Code Review: not-known Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Assisted-by: Copilot Code Review: not-known Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Hey @mpgreaves, just a heads-up for future commits to please follow contributing.md. It helps keep the logs structured and clean. Thanks for the contribution! |
Signed-off-by: Michael Greaves <michael.greaves@nokia.com> Assisted-by: Copilot Code Review:not-known Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
liamfallon
previously approved these changes
Jun 2, 2026
Catalin-Stratulat-Ericsson
previously approved these changes
Jun 30, 2026
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
looks good just a few minor things maybe to patch in before merging
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com> Co-authored-by: Catalin Stratulat <159934629+Catalin-Stratulat-Ericsson@users.noreply.github.com>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
mpgreaves
dismissed stale reviews from Catalin-Stratulat-Ericsson and liamfallon
via
July 9, 2026 06:31
a102120
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
|
liamfallon
approved these changes
Jul 23, 2026
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
aravindtga
reviewed
Aug 27, 2026
|
|
||
| <<<<<<< HEAD | ||
| Details of how to work with packages are set out in [Chapter 3](../03-packages). | ||
| ======= |
Contributor
There was a problem hiding this comment.
Merge conflict need to be resolved.
| - The functions are hermetic. For correctness, security and speed, it is desirable to be able to run functions hermetically without any privileges, thereby preventing out-of-band access to the host filesystem and networking. | ||
|
|
||
| We will discuss the KRM Functions Specification Standard in detail in | ||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
Merge conflict need to be resolved.
| - `kpt fn render`: This command executes the pipeline of functions declared in the package and its subpackages. This is a declarative way to run the functions. | ||
| - `kpt fn eval`: This command executes a given function on the package. The image to run and the `functionConfig` are specified as a CLI argument. This is an imperative way to run functions. Since the function is provided explicitly by the user, an imperative invocation can be more privileged and low-level than a declarative invocation. For example, it can have access to the host system. | ||
|
|
||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
Merge conflict need to be resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.