Skip to content

test: Increase mock photo count to validate screenshot comment#187

Merged
komodgn merged 1 commit intodevelopfrom
test/comparison-comment
Apr 22, 2026
Merged

test: Increase mock photo count to validate screenshot comment#187
komodgn merged 1 commit intodevelopfrom
test/comparison-comment

Conversation

@komodgn
Copy link
Copy Markdown
Owner

@komodgn komodgn commented Apr 22, 2026 •
edited
Loading

Related issue

  • closed #issue_number

Work Description ✏️

Test screenshot-comparison-comment.yml workflow.

Screenshot 📸

Summary by CodeRabbit

  • Chores
    • Expanded sample data collection to support enhanced testing and development workflows for the detail view feature.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The pull request expands the mock photo URI list in PersonDetailMock.kt by increasing the seed range from 28 to 29 entries, generating one additional mocked photo URL for testing purposes.

Changes

Cohort / File(s) Summary
Mock Data Expansion
feature/detail/src/main/java/com/metasearch/android/feature/detail/person/mock/PersonDetailMock.kt		 Expanded fakePhotoUris list from 28 to 29 generated mock photo URLs by adjusting the seed range from (1..28) to (1..29).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

testing

Poem

🐰 One more photo joins the collection,
Twenty-nine now in our selection,
Testing photos, URLs that shine,
Mock data growing, line by line,
Our detail views, they'll surely glow!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: increasing mock photo count from 28 to 29 entries in the fakePhotoUris list to validate screenshot comparison functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/comparison-comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Roborazzi Snapshot Diff Report

File Name Comparison
com.metasearch.andro
id.feature.detail.pe
rson.PersonDetailUiK
t_PersonDetailUiPrev
iew_compare.png
com.metasearch.andro
id.feature.detail.pe
rson.PersonDetailUiK
t_PersonDetailUiEdit
DialogPreview_compar
e.png
com.metasearch.andro
id.feature.detail.pe
rson.PersonDetailUiK
t_PersonDetailUiProf
ileSelectPreview_com
pare.png

github-actions[bot]
github-actions Bot reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Android CI Summary

Step Results:

  • Debug Build: ✅ Success (2m 24s)
  • Code Style Check: ✅ Success (1m 11s)
  • Compose Stability: ✅ Success (46s)

Total Time: 4m 21s

🎉 All steps completed successfully!

@komodgn komodgn merged commit c27a76a into develop Apr 22, 2026
4 checks passed
@komodgn komodgn deleted the test/comparison-comment branch April 22, 2026 06:28
@komodgn komodgn mentioned this pull request Apr 22, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@komodgn