Skip to content

test: Decrease mock photo count to validate Roborazzi diff pipeline#185

Closed
komodgn wants to merge 1 commit intodevelopfrom
test/screenshot-comment
Closed

test: Decrease mock photo count to validate Roborazzi diff pipeline#185
komodgn wants to merge 1 commit intodevelopfrom
test/screenshot-comment

Conversation

@komodgn
Copy link
Copy Markdown
Owner

@komodgn komodgn commented Apr 21, 2026

Related issue

  • closed #issue_number

Work Description ✏️

The issue where unchanged screenshots were being reported (46 total) was caused by "polluted artifacts" in the base branch. The fix has been implemented in #186. Instead of merging this PR, the final verification of the cleaned-up pipeline will be conducted through a separate PR once the updated CI baseline is established.

Screenshot 📸

Expected comments
com metasearch android feature detail person PersonDetailUiKt_PersonDetailUiEditDialogPreview_compare com metasearch android feature detail person PersonDetailUiKt_PersonDetailUiPreview_compare com metasearch android feature detail person PersonDetailUiKt_PersonDetailUiProfileSelectPreview_compare

Summary by CodeRabbit

  • Tests
    • Adjusted mock photo dataset size in person detail testing infrastructure.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

📝 Walkthrough

Walkthrough

The pull request reduces the mock photo URI dataset in PersonDetailMock.kt from 28 entries to 27 entries by adjusting the range from (1..28) to (1..27), affecting the fakePhotoUris variable used in person detail UI state testing.

Changes

Cohort / File(s) Summary
Mock Data Adjustment
feature/detail/src/main/java/com/metasearch/android/feature/detail/person/mock/PersonDetailMock.kt
Reduced fakePhotoUris range from 28 to 27 entries, decreasing the mock photo URI list size.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 One photo flew away today,
From twenty-eight to twenty-seven they stay,
Mock data trimmed with careful paw,
The perfect gallery, without a flaw!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: reducing mock photo count from 28 to 27 entries to validate the Roborazzi screenshot testing pipeline.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/screenshot-comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Roborazzi Snapshot Diff Report

File Name Comparison
com.metasearch.andro
id.core.ui.component
.MetaSearchCircleIma
geKt_MetaSearchCircl
eImagePreview_compar
e.png
com.metasearch.andro
id.feature.search.fo
cusing.component.Mor
eButtonKt_MoreButton
Preview_compare.png
com.metasearch.andro
id.feature.detail.pe
rson.component.Perso
nEditDialogContentKt
_PersonEditContentPr
eview_compare.png
com.metasearch.andro
id.feature.search.nl
s.component.NLSearch
TextFieldKt_NLSearch
TextFieldPreview_com
pare.png
com.metasearch.andro
id.feature.graph.Gra
phUiKt_GraphUiErrorP
review_compare.png
com.metasearch.andro
id.feature.search.fo
cusing.FocusingSearc
hUiKt_FocusingSearch
UiPreview_compare.pn
g
com.metasearch.andro
id.feature.graph.Gra
phUiKt_GraphUiWebVie
wPreview_compare.png
com.metasearch.andro
id.feature.detail.gr
aph.component.Explor
eImageListKt_Explore
ImageListPreview_com
pare.png
com.metasearch.andro
id.core.ui.component
.MetaSearchSearchBar
Kt_MetaSearchSearchB
arPreview_compare.pn
g
com.metasearch.andro
id.feature.detail.pe
rson.PersonDetailUiK
t_PersonDetailUiPrev
iew_compare.png
com.metasearch.andro
id.feature.search.fo
cusing.component.Sea
rchResultListKt_Sear
chResultListPreview_
compare.png
com.metasearch.andro
id.feature.person.Pe
rsonUiKt_PersonUiDel
eteDialogPreview_com
pare.png
com.metasearch.andro
id.feature.screens.c
omponent.MetaSearchM
ainBottomBarKt_MetaS
earchMainBottomBarPr
eview_compare.png
com.metasearch.andro
id.feature.search.fo
cusing.FocusingSearc
hUiKt_FocusingSearch
UiLoadingPreview_com
pare.png
com.metasearch.andro
id.core.ui.component
.MetaSearchDialogKt_
MetaSearchDialogPrev
iew_compare.png
com.metasearch.andro
id.feature.home.Home
UiKt_HomeUiLongClick
Preview_compare.png
com.metasearch.andro
id.core.designsystem
.component.MetaSearc
hButtonKt_MetaSearch
ButtonPreview_compar
e.png
com.metasearch.andro
id.feature.home.Home
UiKt_HomeUiPreview_c
ompare.png
com.metasearch.andro
id.feature.detail.ph
oto.component.PhotoD
etailBottomBarKt_Pho
toDetailBottomBarPre
view_compare.png
com.metasearch.andro
id.core.designsystem
.component.NetworkIm
ageKt_NetworkImagePr
eview_compare.png
com.metasearch.andro
id.core.ui.component
.MetaSearchSquareIma
geKt_MetaSearchSquar
eImagePreview_compar
e.png
com.metasearch.andro
id.core.ui.component
.MetaSearchHeaderKt_
FocusingSearchHeader
Preview_compare.png
com.metasearch.andro
id.feature.detail.ph
oto.component.ImageD
escriptionBottomShee
tContentKt_ImageDesc
riptionBottomSheetCo
ntentPreview_compare
.png
com.metasearch.andro
id.core.ui.component
.MetaSearchDividerKt
_MetaSearchDividerPr
eview_compare.png
com.metasearch.andro
id.feature.home.comp
onent.HomeHeaderKt_H
omeHeaderPreview_com
pare.png
com.metasearch.andro
id.core.designsystem
.component.MetaSearc
hToastKt_MetaSearchT
oastPreview_compare.
png
com.metasearch.andro
id.feature.search.fo
cusing.component.Foc
usingSearchBottomBar
Kt_FocusingSearchBot
tomBarPreview_compar
e.png
com.metasearch.andro
id.feature.search.nl
s.NLSearchUiKt_NLSea
rchUiLoadingPreview_
compare.png
com.metasearch.andro
id.feature.home.comp
onent.PersonCircleIt
emKt_PersonCircleIte
mPreview_compare.png
com.metasearch.andro
id.feature.detail.pe
rson.component.Perso
nDetailHeaderKt_Pers
onDetailHeaderPrevie
w_compare.png
com.metasearch.andro
id.feature.person.co
mponent.PersonSearch
TextFieldKt_PersonSe
archTextFieldPreview
_compare.png
com.metasearch.andro
id.feature.home.comp
onent.PartialAccessB
annerKt_PartialAcces
sBannerPreview_compa
re.png
com.metasearch.andro
id.feature.detail.pe
rson.PersonDetailUiK
t_PersonDetailUiEdit
DialogPreview_compar
e.png
com.metasearch.andro
id.feature.home.Home
UiKt_HomeUiCollapsed
Preview_compare.png
com.metasearch.andro
id.core.designsystem
.component.MetaSearc
hTextFieldKt_MetaSea
rchTextFieldPreview_
compare.png
com.metasearch.andro
id.feature.detail.gr
aph.GraphDetailUiKt_
GraphDetailUiPreview
_compare.png
com.metasearch.andro
id.core.ui.component
.MetaSearchLoadingIn
dicatorKt_MetaSearch
LoadingIndicatorPrev
iew_compare.png
com.metasearch.andro
id.feature.person.Pe
rsonUiKt_PersonUiPre
view_compare.png
com.metasearch.andro
id.feature.search.nl
s.NLSearchUiKt_NLSea
rchUiPreview_compare
.png
com.metasearch.andro
id.feature.person.co
mponent.PersonItemKt
_PersonItemPreview_c
ompare.png
com.metasearch.andro
id.feature.detail.pe
rson.PersonDetailUiK
t_PersonDetailUiProf
ileSelectPreview_com
pare.png
com.metasearch.andro
id.feature.splash.Sp
lashUiKt_SplashUiPre
view_compare.png
com.metasearch.andro
id.core.ui.component
.WebViewErrorUiKt_We
bViewErrorUiPreview_
compare.png
com.metasearch.andro
id.feature.detail.ph
oto.PhotoDetailUiKt_
PhotoDetailUiPreview
_compare.png
com.metasearch.andro
id.feature.graph.Gra
phUiKt_GraphUiPrevie
w_compare.png

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Android CI Summary

Step Results:

  • Debug Build: ✅ Success (2m 30s)
  • Code Style Check: ✅ Success (1m 3s)
  • Compose Stability: ✅ Success (42s)

Total Time: 4m 15s

🎉 All steps completed successfully!

@komodgn komodgn closed this Apr 22, 2026
@komodgn komodgn deleted the test/screenshot-comment branch April 22, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant