fix unifyLabels closed flags and Skolem EQ branch#884
Open
cuiweixie wants to merge 1 commit intokoka-lang:devfrom
Open
fix unifyLabels closed flags and Skolem EQ branch#884cuiweixie wants to merge 1 commit intokoka-lang:devfrom
cuiweixie wants to merge 1 commit intokoka-lang:devfrom
Conversation
The id1 >= id2 case passed ls2 as the first list; mirror the id1 < id2 branch with ls1 and ll2.
cuiweixie
force-pushed
the
fix/unify-labels-skolem-eq-else
branch
from
3e50b1f to
b22cab2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(closed1, closed2)into the recursiveunifyLabelscall instead of(closed2, closed2).id1 >= id2, pass(ls1, ll2)instead of(ls2, ll2)so the case mirrors theid1 < id2branch (ll1/ls2).