Make struct constructors PascalCase#859
Open
omegametabroccolo wants to merge 1 commit intokoka-lang:devfrom
Open
Make struct constructors PascalCase#859omegametabroccolo wants to merge 1 commit intokoka-lang:devfrom
struct constructors PascalCase#859omegametabroccolo wants to merge 1 commit intokoka-lang:devfrom
Conversation
Collaborator
|
I think this is a useful and important change even though it breaks current code. It is better to make this breaking change now while the community is small and almost entirely on the community discord (judging by the Koka code I've seen on github and the number of users in the discord). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #537 and fixes uses of
structconstructors inlib/stdandtest. Not everything was covered by tests so I had to inspect the output ofgrep -R '[A-Z][a-z]*-[a-z]+'manually, I hope I didn't miss anything. Not covered:typeconstructors that don't follow this conventionlib/v1